From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935134AbcHaOXw (ORCPT ); Wed, 31 Aug 2016 10:23:52 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:36731 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933214AbcHaOXv (ORCPT ); Wed, 31 Aug 2016 10:23:51 -0400 Date: Wed, 31 Aug 2016 10:23:48 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Geoff Levand , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ps3: Remove deprecated create_singlethread_workqueue Message-ID: <20160831142348.GJ12660@htj.duckdns.org> References: <20160830171450.GA1890@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160830171450.GA1890@Karyakshetra> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 10:44:51PM +0530, Bhaktipriya Shridhar wrote: > The workqueue "ps3av->wq" queues a single work item &ps3av->work and hence > doesn't require ordering. It is involved in waking up ps3avd to do the > video mode setting and hence it's not being used on a memory reclaim > path. Hence, it has been converted to use system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > The work item has been flushed in ps3av_remove to ensure that > there are no pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun