From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759075AbcHaVRt (ORCPT ); Wed, 31 Aug 2016 17:17:49 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:34191 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbcHaVRs (ORCPT ); Wed, 31 Aug 2016 17:17:48 -0400 Date: Wed, 31 Aug 2016 17:17:45 -0400 From: Tejun Heo To: Peter Ujfalusi Cc: Bhaktipriya Shridhar , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue Message-ID: <20160831211745.GC12660@htj.duckdns.org> References: <20160830182750.GA8074@Karyakshetra> <7abb8b68-760b-cf67-17a5-d120136d6ec5@ti.com> <20160831144408.GX12660@htj.duckdns.org> <88b9a137-b934-f928-535f-719cfbc9bff3@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88b9a137-b934-f928-535f-719cfbc9bff3@ti.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Peter. On Wed, Aug 31, 2016 at 10:10:47PM +0300, Peter Ujfalusi wrote: > > What kind of time frame are we talking about? If it really needs high > > priority, the right thing to do would be using a WQ_HIGHPRI workqueue. > > In order to be tune the performance and power saving during audio playback > lower is better, but consistency matters more to be able have stable system. > I have some latency compensation in the code so it could tolerate some drift, > but big spikes can cause the codec to go underflow and we can not recover from > that w/o hard reset of the codec. Gees, that's a brutal failure mode. > I do believe that Linux got much better over the years since I wrote the dac33 > driver, so I'm fine with the move to system_wq. The most problematic mode (I > think it was MODE7LP or smthing) is not upstream so this change should not > break audio on the n9/n950. Thanks for the explanation! -- tejun