From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932988AbcHaUOL (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 Aug 2016 16:14:11 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:45442 "EHLO
        dd1012.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752760AbcHaUOI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 Aug 2016 16:14:08 -0400
Date: Wed, 31 Aug 2016 22:14:02 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>,
        linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish
 sun4i from sun7i
Message-ID: <20160831221402.670ab832@scratchpost.org>
In-Reply-To: <20160831174623.GA20462@lukather>
References: <20160830054403.7878-1-dannym@scratchpost.org>
        <20160830054403.7878-2-dannym@scratchpost.org>
        <20160831174623.GA20462@lukather>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maxime,

On Wed, 31 Aug 2016 19:46:23 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> > -#define SUN4I_CODEC_AC_SYS_VERI			(0x38)
> > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL		(0x3c)
> > +
> > +#define SUN7I_CODEC_AC_DAC_CAL			(0x38)
> > +#define SUN7I_CODEC_AC_MIC_PHONE_CAL		(0x3c)  
> 
> That will need at least some mention in the commit log.

Hm? It's now called like it is called in the user manual.
Also, the macro SUN4I_CODEC_AC_SYS_VERI was unused before anyway.

What should I write in the commit log?

> It would be better to add a structure assiocated to the data field of
> of_device_id. That way, you'll also be able to have any quirks without
> adding more checks (such as a different regmap config, like Chen-Yu
> suggested).

Yeah, I did that now; seems to work.

Cheers,
   Danny