From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753047AbcIAXjp (ORCPT ); Thu, 1 Sep 2016 19:39:45 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:40800 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbcIAXjn (ORCPT ); Thu, 1 Sep 2016 19:39:43 -0400 Date: Thu, 01 Sep 2016 16:39:42 -0700 (PDT) Message-Id: <20160901.163942.2272956240456598007.davem@davemloft.net> To: dhowells@redhat.com Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users From: David Miller In-Reply-To: <20160901.163832.1923741041602397930.davem@davemloft.net> References: <147257235268.6716.12062621584578937716.stgit@warthog.procyon.org.uk> <147257235952.6716.3613899854387213654.stgit@warthog.procyon.org.uk> <20160901.163832.1923741041602397930.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Sep 2016 16:39:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u81NdogK016123 From: David Miller Date: Thu, 01 Sep 2016 16:38:32 -0700 (PDT) > From: David Howells > Date: Tue, 30 Aug 2016 16:52:39 +0100 > >> Don't expose skbs to in-kernel users, such as the AFS filesystem, but >> instead provide a notification hook the indicates that a call needs >> attention and another that indicates that there's a new call to be >> collected. > ... >> Signed-off-by: David Howells > > Applied. Actually, reverted, this adds a new warning to the build: net/rxrpc/recvmsg.c: In function ¡rxrpc_kernel_recv_data¢: net/rxrpc/recvmsg.c:531:1: warning: label ¡need_more_data¢ defined but not used [-Wunused-label] need_more_data: ^ net/rxrpc/recvmsg.c:475:7: warning: unused variable ¡no_more¢ [-Wunused-variable] bool no_more; ^