From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbcIAIdC (ORCPT ); Thu, 1 Sep 2016 04:33:02 -0400 Received: from foss.arm.com ([217.140.101.70]:51382 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcIAIc6 (ORCPT ); Thu, 1 Sep 2016 04:32:58 -0400 Date: Thu, 1 Sep 2016 09:33:12 +0100 From: Morten Rasmussen To: peterz@infradead.org, mingo@redhat.com Cc: dietmar.eggemann@arm.com, yuyang.du@intel.com, vincent.guittot@linaro.org, mgalbraith@suse.de, sgurrappadi@nvidia.com, freedom.tan@mediatek.com, keita.kobayashi.ym@renesas.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/5] sched: Clean-ups and asymmetric cpu capacity support Message-ID: <20160901083311.GA9409@e105550-lin.cambridge.arm.com> References: <1472640739-8778-1-git-send-email-morten.rasmussen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472640739-8778-1-git-send-email-morten.rasmussen@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 11:52:14AM +0100, Morten Rasmussen wrote: > v4: > > - Removed patches already in tip/sched/core. Just discovered an error on the comment of one of those patches :-/ ----8<---- >>From a0040f8dfe60696d7e6429f50906d6b17671bbcc Mon Sep 17 00:00:00 2001 From: Morten Rasmussen Date: Thu, 1 Sep 2016 09:24:35 +0100 Subject: [PATCH] sched/fair: Fix wrong comment for capacity_margin The comment for capacity_margin introduced in "sched/fair: Let asymmetric cpu configurations balance at wake-up" got its usage the wrong way round. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 27534e36555b..161fd8eba234 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -116,7 +116,7 @@ unsigned int sysctl_sched_cfs_bandwidth_slice = 5000UL; /* * The margin used when comparing utilization with CPU capacity: - * util * 1024 < capacity * margin + * util * margin < capacity * 1024 */ unsigned int capacity_margin = 1280; /* ~20% */ -- 1.9.1