From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755976AbcIAVCK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 17:02:10 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:58876 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755848AbcIAVCE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 17:02:04 -0400
Date: Thu, 1 Sep 2016 22:45:47 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        Andy Lutomirski <luto@kernel.org>, Arve Hj?nnev?g <arve@android.com>,
        Michael Ryleev <gmar@google.com>, Joao Pinto <Joao.Pinto@synopsys.com>,
        Christoph Hellwig <hch@lst.de>, Yaniv Gardi <ygardi@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v5 5/8] char: rpmb: add RPMB simulation device
Message-ID: <20160901204547.GA5960@kroah.com>
References: <1468873673-21776-1-git-send-email-tomas.winkler@intel.com>
 <1468873673-21776-6-git-send-email-tomas.winkler@intel.com>
 <20160831105845.GE10180@kroah.com>
 <5B8DA87D05A7694D9FA63FD143655C1B542C5B98@hasmsx108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542C5B98@hasmsx108.ger.corp.intel.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 01, 2016 at 08:25:28PM +0000, Winkler, Tomas wrote:
> > On Mon, Jul 18, 2016 at 11:27:50PM +0300, Tomas Winkler wrote:
> > > This is a simple platform device used for testing the RPMB subsystem.
> > > +static struct platform_device *rpmb_sim_pdev;
> > 
> > A platform device?  Ick, no please don't abuse that interface for this type of
> > thing.  Make it a real device if you have one, and put it in the proper place.  If
> > it's a "virtual" device, great, use that.  But don't make something up like this
> > please.
> 
> This is a virtual device (simulation), nothing behind it just a chunk of memory.
> Is this there any information missing to make it clearer? 

Don't make it a platform device, make it a "virtual" device, don't abuse
the platform device/driver interface for something that isn't really a
platform device.

thanks,

greg k-h