From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752057AbcIBGKd (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Sep 2016 02:10:33 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:39764 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751346AbcIBGKc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Sep 2016 02:10:32 -0400
Date: Fri, 2 Sep 2016 08:10:40 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
        John Stultz <john.stultz@linaro.org>,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>, linaro-mm-sig@lists.linaro.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Eun Taik Lee <eun.taik.lee@samsung.com>,
        Liviu Dudau <Liviu.Dudau@arm.com>, Jon Medhurst <tixy@linaro.org>,
        Mitchel Humpherys <mitchelh@codeaurora.org>,
        Jeremy Gebben <jgebben@codeaurora.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Android Kernel Team <kernel-team@android.com>,
        Chen Feng <puck.chen@hisilicon.com>,
        Brian Starkey <brian.starkey@arm.com>
Subject: Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI
 checking
Message-ID: <20160902061040.GB13294@kroah.com>
References: <1472769644-11039-1-git-send-email-labbott@redhat.com>
 <1472769644-11039-4-git-send-email-labbott@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1472769644-11039-4-git-send-email-labbott@redhat.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote:
> 
> The current Ion ioctls lack a good way to tell what ioctls are
> available. Introduce an ioctl to give an ABI version. This way when the
> ABI inevitably gets screwed up userspace will have a way to tell what
> version of the screw up is available.

This worries me.  Why do we need this?  Shouldn't any "new" abi changes
just add on, and not change existing ioctl structure calls?  Or worst
case, you remove an ioctl and then userspace "knows" that when the call
fails.

And who is the major userspace user of this interface?  Who controls it?
How are we keeping things in sync here?

thanks,

greg k-h