From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754192AbcIBO41 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Sep 2016 10:56:27 -0400
Received: from mail-yw0-f195.google.com ([209.85.161.195]:34897 "EHLO
        mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752384AbcIBO4Z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Sep 2016 10:56:25 -0400
Date: Fri, 2 Sep 2016 10:56:22 -0400
From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <axboe@fb.com>
Cc: kernel test robot <xiaolong.ye@intel.com>, lkp@01.org,
        Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [writeback] 8bc4ad9498: INFO: suspicious RCU usage. ]
Message-ID: <20160902145622.GH12660@htj.duckdns.org>
References: <57c8012a.zlFYe5dba5wTaKD+%xiaolong.ye@intel.com>
 <25429877-af98-30b2-1980-6686a7b7b78f@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <25429877-af98-30b2-1980-6686a7b7b78f@fb.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

(cc'ing Paul, hi!)

Hello,

On Thu, Sep 01, 2016 at 02:13:34PM -0600, Jens Axboe wrote:
> On 09/01/2016 04:21 AM, kernel test robot wrote:
> > [    7.323356] cdrom: Uniform CD-ROM driver Revision: 3.20
> > [    7.334239]
> > [    7.337256] ===============================
> > [    7.340532] [ INFO: suspicious RCU usage. ]
> > [    7.342419] 4.8.0-rc4-00008-g8bc4ad9 #1 Not tainted
> > [    7.347065] -------------------------------
> > [    7.350132] include/linux/cgroup.h:435 suspicious rcu_dereference_check() usage!
...
> > [    7.410074] Call Trace:
> > [    7.411328]  [<ffffffff8178ed3b>] dump_stack+0x82/0xb8
> > [    7.413982]  [<ffffffff81123472>] lockdep_rcu_suspicious+0xf7/0x100
> > [    7.415828]  [<ffffffff817873f4>] bio_blkcg+0x89/0x93
> > [    7.417336]  [<ffffffff817891f0>] check_blkcg_changed+0x58/0x1b8
> > [    7.428722]  [<ffffffff81789b90>] cfq_set_request+0xd1/0x2a3
> > [    7.439690]  [<ffffffff81763fe3>] elv_set_request+0x1f/0x24
> > [    7.442157]  [<ffffffff8176856d>] get_request+0x38f/0x77f
> > [    7.447449]  [<ffffffff817689c2>] blk_get_request+0x65/0xa8
> > [    7.449868]  [<ffffffff81c692df>] ide_cd_queue_pc+0x76/0x19d
> > [    7.453757]  [<ffffffff81c695ee>] cdrom_check_status+0x51/0x53
> > [    7.455372]  [<ffffffff81c6a27e>] ide_cdrom_check_events_real+0x20/0x3f
> > [    7.457294]  [<ffffffff82579f94>] cdrom_update_events+0x18/0x21
> > [    7.458987]  [<ffffffff82579faf>] cdrom_check_events+0x12/0x1f
> > [    7.460713]  [<ffffffff81c68317>] idecd_check_events+0x1c/0x1e
> > [    7.462393]  [<ffffffff81778d12>] disk_check_events+0x47/0x103
> > [    7.464129]  [<ffffffff81778dea>] disk_events_workfn+0x1c/0x1e
> > [    7.465844]  [<ffffffff810fcafa>] process_one_work+0x272/0x4ee
> > [    7.467462]  [<ffffffff810fd247>] worker_thread+0x1eb/0x2c9

The warning is from

#define task_css_set_check(task, __c)					\
	rcu_dereference_check((task)->cgroups,				\
		lockdep_is_held(&cgroup_mutex) ||			\
		lockdep_is_held(&css_set_lock) ||			\
		((task)->flags & PF_EXITING) || (__c))

which is used by bio_blkcg() which is called by the following code in
check_blkcg_changed().

	rcu_read_lock();
	serial_nr = bio_blkcg(bio)->css.serial_nr;
	rcu_read_unlock();

So, I have no idea.  It looks like rcu_dereference_check() is being
called with rcu read locked but still triggering suspicious RCU usage
warning.

The code hasn't changed for quite a while now, so it's also really
weird that it's triggering now.  Paul, does anything ring a bell?

Thanks.

-- 
tejun