From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932636AbcIBPfE (ORCPT ); Fri, 2 Sep 2016 11:35:04 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36816 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932467AbcIBPfB (ORCPT ); Fri, 2 Sep 2016 11:35:01 -0400 Date: Fri, 2 Sep 2016 10:34:59 -0500 From: Rob Herring To: Richard Fitzgerald Cc: lee.jones@linaro.org, patches@opensource.wolfsonmicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config Message-ID: <20160902153458.GA28352@rob-hp-laptop> References: <1472635543-21577-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472635543-21577-1-git-send-email-rf@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 10:25:43AM +0100, Richard Fitzgerald wrote: > This patch adds DT settings for the max_channels_clocked, spk_fmt and > spk_mute pdata. > > Signed-off-by: Richard Fitzgerald > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 11 ++++++++ Binding looks fine, but... > drivers/mfd/arizona-core.c | 31 +++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index b95ff2d..36a9633 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -816,6 +816,37 @@ static int arizona_of_get_core_pdata(struct arizona *arizona) > count++; > } > > + count = 0; > + of_property_for_each_u32(arizona->dev->of_node, > + "wlf,max-channels-clocked", > + prop, cur, val) { > + if (count == ARRAY_SIZE(pdata->max_channels_clocked)) > + break; > + > + pdata->max_channels_clocked[count] = val; > + count++; > + } of_property_read_u32_array doesn't work for you? > + > + count = 0; > + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-fmt", prop, > + cur, val) { > + if (count == ARRAY_SIZE(pdata->spk_fmt)) > + break; > + > + pdata->spk_fmt[count] = val; > + count++; > + } > + > + count = 0; > + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-mute", prop, > + cur, val) { > + if (count == ARRAY_SIZE(pdata->spk_mute)) > + break; > + > + pdata->spk_mute[count] = val; > + count++; > + } > + > return 0; > } > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html