From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933508AbcIEKb0 (ORCPT ); Mon, 5 Sep 2016 06:31:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40153 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933448AbcIEKbV (ORCPT ); Mon, 5 Sep 2016 06:31:21 -0400 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: schwidefsky@de.ibm.com X-IBM-RcptTo: kernel-janitors@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Mon, 5 Sep 2016 12:31:03 +0200 From: Martin Schwidefsky To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Subject: Re: [PATCH 00/17] s390/debug: Fine-tuning for several function implementations In-Reply-To: References: <566ABCD9.1060404@users.sourceforge.net> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16090510-0012-0000-0000-00000450FDA3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16090510-0013-0000-0000-00001544352D Message-Id: <20160905123103.2c587d60@mschwide> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-05_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609050159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Sep 2016 14:04:18 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 3 Sep 2016 13:54:32 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (17): > Use kmalloc_array() in debug_areas_alloc() > Delete unnecessary braces > Add some spaces for better code readability > Rename jump labels in debug_areas_alloc() > Fix jump targets in debug_info_alloc() > Rename jump labels in debug_info_copy() > Rename jump labels in debug_open() > Fix a jump target in debug_register_mode() > Return directly if a null pointer was passed to debug_unregister() > Delete an unnecessary initialisation in debug_prolog_level_fn() > Fix indentation in 13 functions > Use memdup_user() rather than duplicating its implementation > Improve a size determination in debug_open() > Improve a size determination in debug_sprintf_format_fn() > Improve a size determination in debug_raw_header_fn() > Improve determination of sizes in debug_info_alloc() > Improve another size determination in debug_info_alloc() > > arch/s390/kernel/debug.c | 433 ++++++++++++++++++++++------------------------- > 1 file changed, 204 insertions(+), 229 deletions(-) While I agree that the old code in arch/s390/kernel/debug.c does not abide to the current coding style standards, I doubt there is much value in these patches. To be honest I got annoyed after the third patch and stopped reading after the forth. NAK. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.