From: Lee Jones <lee.jones@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
vinod.koul@intel.com, patrice.chotard@st.com,
dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com,
ohad@wizery.com, bjorn.andersson@linaro.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes
Date: Mon, 5 Sep 2016 16:42:48 +0100 [thread overview]
Message-ID: <20160905154248.GU4921@dell> (raw)
In-Reply-To: <ae089830-b7c8-ee83-f697-6ff93f2646ed@st.com>
On Mon, 05 Sep 2016, Arnaud Pouliquen wrote:
> >>>> + dai-name = "Uni Reader #0 (PCM IN)";
> >>>
> >>> Oooo, not seen something like this before.
> >>>
> >>> If it does not already have one, it would require a DT Ack.
> >>
> >> No idea, the driver got merged 1 year ago.
> This field could be suppressed and handled in source code, using
> st,uniperiph-id to retreive it.
That would be better.
> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had sent to Alsa mailing list only, I missed
> this obvious...
I'm surprised Mark didn't notice this.
He's usually pretty good at picking stuff like that up.
> >>>> + st,version = <3>;
> >>>
> >>> This will likely need a DT Ack too. We usually encode this sort of
> >>> information in the compatible string.
> yes, better to use compatibility
> >>
> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c
> >
> > Well Rob's the boss. We certainly never used to take 'device ID' or
> > 'version' attributes. I guess something must have changed.
>
> I will try to provide patches for code and bindings rework this week.
Wonderful.. Thanks Arnaud.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-09-05 15:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 14:56 [PATCH v8 00/18] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-08-26 14:56 ` [PATCH v8 01/18] remoteproc: st_slim_rproc: add a slimcore rproc driver Peter Griffin
2016-08-30 12:34 ` Lee Jones
2016-08-30 15:44 ` Peter Griffin
2016-08-31 11:24 ` Lee Jones
2016-08-30 16:54 ` Bjorn Andersson
2016-08-31 11:11 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 02/18] MAINTAINERS: Add st slim core rproc driver to STi section Peter Griffin
2016-08-30 10:27 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2016-08-26 14:56 ` [PATCH v8 04/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-08-26 14:56 ` [PATCH v8 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-08-30 16:30 ` Vinod Koul
2016-09-01 10:06 ` Peter Griffin
2016-08-26 14:56 ` [PATCH v8 06/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2016-08-30 10:26 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 07/18] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-08-26 14:56 ` [PATCH v8 08/18] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-08-26 14:56 ` [PATCH v8 09/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-08-30 10:25 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 10/18] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin
2016-08-30 10:24 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 11/18] ARM: DT: STiH407: Add i2s_in " Peter Griffin
2016-08-30 10:23 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 12/18] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin
2016-08-30 10:22 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 13/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin
2016-08-30 10:03 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 14/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin
2016-08-30 10:02 ` Lee Jones
2016-08-30 10:03 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader " Peter Griffin
2016-08-30 10:01 ` Lee Jones
2016-08-30 14:21 ` Peter Griffin
2016-08-31 11:28 ` Lee Jones
2016-09-05 12:20 ` Arnaud Pouliquen
2016-09-05 15:42 ` Lee Jones [this message]
2016-08-26 14:56 ` [PATCH v8 16/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin
2016-08-30 9:56 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 17/18] drm/virtio: kconfig: Fix recursive dependency Peter Griffin
2016-08-30 9:55 ` Lee Jones
2016-08-26 14:56 ` [PATCH v8 18/18] drm/virtio: kconfig: Fixup white space Peter Griffin
2016-08-30 9:54 ` Lee Jones
2016-08-30 9:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905154248.GU4921@dell \
--to=lee.jones@linaro.org \
--cc=airlied@linux.ie \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@stlinux.com \
--cc=kraxel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
--cc=vinod.koul@intel.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).