From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Pavel Andrianov <andrianov@ispras.ru>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shraddha Barke <shraddha.6596@gmail.com>,
Dilek Uzulmez <dilekuzulmez@gmail.com>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, vaishali.thakkar@oracle.com,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] speakup: Add spinlock in synth_direct_store
Date: Mon, 5 Sep 2016 23:55:43 +0200 [thread overview]
Message-ID: <20160905215543.GO4779@var.home> (raw)
In-Reply-To: <1473081467-1892-1-git-send-email-andrianov@ispras.ru>
Pavel Andrianov, on Mon 05 Sep 2016 16:17:47 +0300, wrote:
> All operations with synth buffer should be protected,
> as there are global pointers, which should be modified atomically.
>
> Found by Linux Driver Verification project (linuxtesting.org)
>
> Signed-off-by: Pavel Andrianov <andrianov@ispras.ru>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/kobjects.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 528cbdc..7fedee3 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -411,11 +411,13 @@ static ssize_t synth_direct_store(struct kobject *kobj,
> int len;
> int bytes;
> const char *ptr = buf;
> + unsigned long flags;
>
> if (!synth)
> return -EPERM;
>
> len = strlen(buf);
> + spin_lock_irqsave(&speakup_info.spinlock, flags);
> while (len > 0) {
> bytes = min_t(size_t, len, 250);
> strncpy(tmp, ptr, bytes);
> @@ -425,6 +427,7 @@ static ssize_t synth_direct_store(struct kobject *kobj,
> ptr += bytes;
> len -= bytes;
> }
> + spin_unlock_irqrestore(&speakup_info.spinlock, flags);
> return count;
> }
>
> --
> 2.7.4
>
--
Samuel
Linux, c'est simple : ça s'adresse à une machine qui est parfois un peu
maraboutée mais qui d'habitude n'a pas d'états d'âme. Sur Usenet y'a
plein d'humains et de primates, et ça devient vraiment gore par moment.
-+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une âme ?" -+-
next prev parent reply other threads:[~2016-09-05 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 13:17 [PATCH] speakup: Add spinlock in synth_direct_store Pavel Andrianov
2016-09-05 21:55 ` Samuel Thibault [this message]
2016-09-06 3:29 ` Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905215543.GO4779@var.home \
--to=samuel.thibault@ens-lyon.org \
--cc=andrianov@ispras.ru \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
--cc=speakup@linux-speakup.org \
--cc=vaishali.thakkar@oracle.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).