From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936212AbcIFW7q (ORCPT ); Tue, 6 Sep 2016 18:59:46 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55946 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932753AbcIFW7p (ORCPT ); Tue, 6 Sep 2016 18:59:45 -0400 Date: Tue, 06 Sep 2016 15:59:43 -0700 (PDT) Message-Id: <20160906.155943.300054680399189957.davem@davemloft.net> To: baoyou.xie@linaro.org Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static From: David Miller In-Reply-To: <1473149519-25993-1-git-send-email-baoyou.xie@linaro.org> References: <1473149519-25993-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Sep 2016 15:59:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baoyou Xie Date: Tue, 6 Sep 2016 16:11:59 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie This doesn't apply cleanly to net-next.