From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932641AbcIFGYj (ORCPT ); Tue, 6 Sep 2016 02:24:39 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49947 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183AbcIFGYi (ORCPT ); Tue, 6 Sep 2016 02:24:38 -0400 Date: Mon, 5 Sep 2016 23:24:35 -0700 From: Christoph Hellwig To: Colin King Cc: Keith Busch , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-rdma: fix null pointer dereference on req->mr Message-ID: <20160906062435.GA25322@infradead.org> References: <20160905152438.14299-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160905152438.14299-1-colin.king@canonical.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2016 at 04:24:38PM +0100, Colin King wrote: > From: Colin Ian King > > If there is an error on req->mr, req->mr is set to null, however > the following statement sets req->mr->need_inval causing a null > pointer dereference. Fix this by bailing out to label 'out' to > immediately return and hence skip over the offending null pointer > dereference. > > Fixes: f5b7b559e1488 ("nvme-rdma: Get rid of duplicate variable") > Signed-off-by: Colin Ian King Looks fine, Reviewed-by: Christoph Hellwig