From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: Question on smp_mb__before_spinlock
Date: Tue, 6 Sep 2016 13:17:53 +0200 [thread overview]
Message-ID: <20160906111753.GA10121@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160905101021.GC2649@arm.com>
On Mon, Sep 05, 2016 at 11:10:22AM +0100, Will Deacon wrote:
> > The second issue I wondered about is spinlock transitivity. All except
> > powerpc have RCsc locks, and since Power already does a full mb, would
> > it not make sense to put it _after_ the spin_lock(), which would provide
> > the same guarantee, but also upgrades the section to RCsc.
> >
> > That would make all schedule() calls fully transitive against one
> > another.
>
> It would also match the way in which the arm64 atomic_*_return ops
> are implemented, since full barrier semantics are required there.
Hmm, are you sure; the way I read arch/arm64/include/asm/atomic_ll_sc.h
is that you do ll/sc-rel + mb.
> > That is, would something like the below make sense?
>
> Works for me, but I'll do a fix to smp_mb__before_spinlock anyway for
> the stable tree.
Indeed, thanks!
>
> The only slight annoyance is that, on arm64 anyway, a store-release
> appearing in program order before the LOCK operation will be observed
> in order, so if the write of CONDITION=1 in the try_to_wake_up case
> used smp_store_release, we wouldn't need this barrier at all.
Right, but this is because your load-acquire and store-release are much
stronger than Linux's. Not only are they RCsc, they are also globally
ordered irrespective of the variable (iirc).
This wouldn't work for PPC (even if we could find all such prior
stores).
OK, I suppose I'll go stare what we can do about the mm_types.h use and
spin a patch with Changelog.
next prev parent reply other threads:[~2016-09-06 11:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 9:37 Question on smp_mb__before_spinlock Peter Zijlstra
2016-09-05 9:56 ` kbuild test robot
2016-09-05 10:19 ` Peter Zijlstra
2016-09-05 11:26 ` Fengguang Wu
2016-09-05 10:10 ` Will Deacon
2016-09-06 11:17 ` Peter Zijlstra [this message]
2016-09-06 17:42 ` Will Deacon
2016-09-05 10:37 ` Paul E. McKenney
2016-09-05 11:34 ` Peter Zijlstra
2016-09-05 13:57 ` Paul E. McKenney
2016-09-05 10:51 ` kbuild test robot
2016-09-07 12:17 ` Nicholas Piggin
2016-09-07 13:23 ` Peter Zijlstra
2016-09-07 13:51 ` Will Deacon
2016-09-12 2:35 ` Nicholas Piggin
2016-09-12 2:27 ` Nicholas Piggin
2016-09-12 12:54 ` Peter Zijlstra
2016-09-13 2:05 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906111753.GA10121@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).