From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Dmitry Safonov <dsafonov@virtuozzo.com>
Subject: [for-next][PATCH 1/7] tracing/uprobe: Drop isdigit() check in create_trace_uprobe
Date: Tue, 06 Sep 2016 09:39:33 -0400 [thread overview]
Message-ID: <20160906134000.162585126@goodmis.org> (raw)
In-Reply-To: 20160906133932.473440583@goodmis.org
[-- Attachment #1: 0001-tracing-uprobe-Drop-isdigit-check-in-create_trace_up.patch --]
[-- Type: text/plain, Size: 1292 bytes --]
From: Dmitry Safonov <dsafonov@virtuozzo.com>
It's useless. Before:
[tracing]# echo 'p:test /a:0x0' >> uprobe_events
[tracing]# echo 'p:test a:0x0' >> uprobe_events
-bash: echo: write error: No such file or directory
[tracing]# echo 'p:test 1:0x0' >> uprobe_events
-bash: echo: write error: Invalid argument
After:
[tracing]# echo 'p:test 1:0x0' >> uprobe_events
-bash: echo: write error: No such file or directory
Link: http://lkml.kernel.org/r/20160825152110.25663-3-dsafonov@virtuozzo.com
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_uprobe.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index c53485441c88..a74f2d9ff379 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
pr_info("Probe point is not specified.\n");
return -EINVAL;
}
- if (isdigit(argv[1][0])) {
- pr_info("probe point must be have a filename.\n");
- return -EINVAL;
- }
arg = strchr(argv[1], ':');
if (!arg) {
ret = -EINVAL;
--
2.8.1
next prev parent reply other threads:[~2016-09-06 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:39 [for-next][PATCH 0/7] tracing: Updates for 4.9 Steven Rostedt
2016-09-06 13:39 ` Steven Rostedt [this message]
2016-09-06 13:39 ` [for-next][PATCH 2/7] function_graph: Handle TRACE_BPUTS in print_graph_comment Steven Rostedt
2016-09-06 13:39 ` [for-next][PATCH 3/7] ftrace: Access ret_stack->subtime only in the function profiler Steven Rostedt
2016-09-06 13:39 ` [for-next][PATCH 4/7] tracing: Added hardware latency tracer Steven Rostedt
2016-09-06 13:39 ` [for-next][PATCH 5/7] tracing: Add documentation for hwlat_detector tracer Steven Rostedt
2016-09-06 13:39 ` [for-next][PATCH 6/7] tracing: Have hwlat trace migrate across tracing_cpumask CPUs Steven Rostedt
2016-09-06 13:39 ` [for-next][PATCH 7/7] tracing: Add NMI tracing in hwlat detector Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906134000.162585126@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=dsafonov@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).