From: Oleg Nesterov <oleg@redhat.com>
To: chengchao <chengchao@kedacom.com>
Cc: mingo@kernel.org, peterz@infradead.org, tj@kernel.org,
akpm@linux-foundation.org, chris@chris-wilson.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/core: simpler function for sched_exec migration
Date: Tue, 6 Sep 2016 17:22:54 +0200 [thread overview]
Message-ID: <20160906152253.GB17586@redhat.com> (raw)
In-Reply-To: <db5c6fcd-ae5d-0f41-2d45-d161421cf9c4@kedacom.com>
On 09/06, chengchao wrote:
>
> the key point is for CONFIG_PREEMPT_NONE=y,
> ...
> it is too much overhead for one task(fork()+exec()), isn't it?
Yes, yes, I see, this is suboptimal. Not sure we actually do care,
but yes, perhaps another helper which migrates the current task makes
sense, I dunno.
But,
> > stop_one_cpu_sync() assumes that cpu == smp_processor_id/task_cpu(current),
> > and thus the stopper thread should preempt us at least after schedule()
> > (if CONFIG_PREEMPT_NONE), so we do not need to synchronize.
> >
> yes. the stop_one_cpu_sync is not a good name, stop_one_cpu_schedule is better?
> there is nothing about synchronization.
We need to synchronize with the stopper to ensure it can't touch
cpu_stop_work on stack after stop_one_cpu_sync() returns, and
> > But this is not necessarily true? This task can migrate to another CPU
> > before cpu_stop_queue_work() ?
> >
> before sched_exec() calls stop_one_cpu()/cpu_stop_queue_work(), this
> task(current) cannot migrate to another cpu,because this task is running
> on the cpu.
Why? The running task can migrate to another CPU at any moment. Unless it
runs with preemption disabled or CONFIG_PREEMPT_NONE=y.
And this means that cpu_stop_queue_work() can queue the work on another
CPU != smp_processor_id(), and in this case the kernel can crash because
the pending cpu_stop_work can be overwritten right after return.
So you need something like
void stop_one_cpu_sync(cpu_stop_fn_t fn, void *arg)
{
struct cpu_stop_work work = { .fn = fn, .arg = arg, .done = NULL };
preempt_disable();
cpu_stop_queue_work(raw_smp_processor_id(), &work);
preempt_enable_no_resched();
schedule();
}
or I am totally confused. Note that it doesn't (and shouldn't) have
the "int cpu" argument.
Oleg.
next prev parent reply other threads:[~2016-09-06 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 6:20 [PATCH] sched/core: simpler function for sched_exec migration cheng chao
2016-09-05 13:11 ` Oleg Nesterov
2016-09-06 2:11 ` chengchao
2016-09-06 15:22 ` Oleg Nesterov [this message]
2016-09-07 3:22 ` chengchao
2016-09-07 12:35 ` Oleg Nesterov
2016-09-08 2:17 ` chengchao
2016-09-09 10:05 ` Peter Zijlstra
2016-09-09 1:39 ` [lkp] [sched/core] 3d26b7622f: BUG: unable to handle kernel NULL pointer dereference at 00000001 kernel test robot
2016-09-09 2:04 ` chengchao
2016-09-09 2:26 ` Ye Xiaolong
2016-09-09 2:36 ` chengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906152253.GB17586@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chengchao@kedacom.com \
--cc=chris@chris-wilson.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).