From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754444AbcIFKZi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 06:25:38 -0400
Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:43240 "EHLO
        mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752190AbcIFKZh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 06:25:37 -0400
Date: Tue, 6 Sep 2016 18:20:48 +0800
From: Jisheng Zhang <jszhang@marvell.com>
To: Mark Rutland <mark.rutland@arm.com>
CC: <sebastian.hesselbarth@gmail.com>, <robh+dt@kernel.org>,
        <catalin.marinas@arm.com>, <will.deacon@arm.com>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to
 /soc node
Message-ID: <20160906182048.222cec2f@xhacker>
In-Reply-To: <20160906102208.GB1425@leverpostej>
References: <20160906085557.4019-1-jszhang@marvell.com>
        <20160906085557.4019-2-jszhang@marvell.com>
        <20160906102208.GB1425@leverpostej>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-06_04:,,
 signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000
 definitions=main-1609060162
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

On Tue, 6 Sep 2016 11:22:08 +0100 Mark Rutland wrote:

> On Tue, Sep 06, 2016 at 04:55:55PM +0800, Jisheng Zhang wrote:
> > This patch fixes the following DTC warning with W=1:
> > 
> > "Node /soc has a reg or ranges property, but no unit name"
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>  
> 
> The node is only compatible with simple-bus, and so shouldn't have a
> reg.

IIUC, the warning is caused by "ranges = <0 0 0xf7000000 0x1000000>;"

Thanks,
Jisheng

> 
> Why not remove the reg?
> 
> Mark
> 
> > ---
> >  arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > index 099ad93..2d6f91f 100644
> > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > @@ -134,7 +134,7 @@
> >  			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> >  	};
> >  
> > -	soc {
> > +	soc@f7000000 {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -- 
> > 2.9.3
> >