From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977AbcIHAh4 (ORCPT ); Wed, 7 Sep 2016 20:37:56 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:50492 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbcIHAhu (ORCPT ); Wed, 7 Sep 2016 20:37:50 -0400 Date: Wed, 07 Sep 2016 17:37:46 -0700 (PDT) Message-Id: <20160907.173746.787161029125318872.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net-next 0/3] r8152: configuration setting From: David Miller In-Reply-To: <1394712342-15778-215-Taiwan-albertk@realtek.com> References: <1394712342-15778-215-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 07 Sep 2016 17:37:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Wed, 7 Sep 2016 16:12:19 +0800 > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB > configuration value which they want. The default is to support vendor mode > only. By forcing a certain mode via a Kconfig value, you are basically making it impossible for distributions to do something reasonable here. This needs to be somehow a runtime thing, and I'm pretty sure we've had many other situations of USB devices which want to be run by different "personality" drivers in the past. Perhaps we can do something generically for USB devices for this kind of situation and make r8152 use it. Thanks.