From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935958AbcIGMMz (ORCPT ); Wed, 7 Sep 2016 08:12:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35379 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933904AbcIGMMr (ORCPT ); Wed, 7 Sep 2016 08:12:47 -0400 Date: Wed, 7 Sep 2016 14:12:34 +0200 From: Alexandre Belloni To: Baolin Wang Cc: a.zummo@towertech.it, rostedt@goodmis.org, mingo@redhat.com, john.stultz@linaro.org, tglx@linutronix.de, broonie@kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH] rtc: Add some dummy static inline functions Message-ID: <20160907121234.wrmxikrkrnw6lm7z@piout.net> References: <08716c8296f91fc43a64fbd0a4145b451a02f161.1473232117.git.baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08716c8296f91fc43a64fbd0a4145b451a02f161.1473232117.git.baolin.wang@linaro.org> User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2016 at 15:17:26 +0800, Baolin Wang wrote : > Add some dummy static inline functions in case CONFIG_RTC_LIB is not defined. > The question your commit log should answer is why? > Signed-off-by: Baolin Wang > Fixes: a0a6e06d545a ("time: alarmtimer: Add tracepoints for alarmtimers") > --- > include/linux/rtc.h | 49 ++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 48 insertions(+), 1 deletion(-) > > diff --git a/include/linux/rtc.h b/include/linux/rtc.h > index b693ada..521f752 100644 > --- a/include/linux/rtc.h > +++ b/include/linux/rtc.h > @@ -16,13 +16,60 @@ > #include > #include > > +#ifdef CONFIG_RTC_LIB > extern int rtc_month_days(unsigned int month, unsigned int year); > -extern int rtc_year_days(unsigned int day, unsigned int month, unsigned int year); > +extern int rtc_year_days(unsigned int day, unsigned int month, > + unsigned int year); > extern int rtc_valid_tm(struct rtc_time *tm); > extern time64_t rtc_tm_to_time64(struct rtc_time *tm); > extern void rtc_time64_to_tm(time64_t time, struct rtc_time *tm); > ktime_t rtc_tm_to_ktime(struct rtc_time tm); > struct rtc_time rtc_ktime_to_tm(ktime_t kt); > +#else > +static inline int rtc_month_days(unsigned int month, unsigned int year) > +{ > + return 0; > +} > + > +static inline int rtc_year_days(unsigned int day, unsigned int month, > + unsigned int year) > +{ > + return 0; > +} > + > +static inline int rtc_valid_tm(struct rtc_time *tm) > +{ > + return 0; > +} > + > +static inline time64_t rtc_tm_to_time64(struct rtc_time *tm) > +{ > + time64_t ret; > + > + memset(&ret, 0, sizeof(time64_t)); > + return ret; > +} > + > +static inline void rtc_time64_to_tm(time64_t time, struct rtc_time *tm) > +{ > +} > + > +static inline ktime_t rtc_tm_to_ktime(struct rtc_time tm) > +{ > + ktime_t ret; > + > + memset(&ret, 0, sizeof(ktime_t)); > + return ret; > +} > + > +static inline struct rtc_time rtc_ktime_to_tm(ktime_t kt) > +{ > + struct rtc_time ret; > + > + memset(&ret, 0, sizeof(struct rtc_time)); > + return ret; > +} > +#endif > > /* > * rtc_tm_sub - Return the difference in seconds. > -- > 1.7.9.5 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com