From: Neil Horman <nhorman@tuxdriver.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: marcelo.leitner@gmail.com, vyasevich@gmail.com,
davem@davemloft.net, linux-sctp@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sctp: Remove some redundant code
Date: Wed, 7 Sep 2016 11:19:42 -0400 [thread overview]
Message-ID: <20160907151942.GB21945@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1472981893-8608-1-git-send-email-christophe.jaillet@wanadoo.fr>
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> hidden in 'sctp_skb_list_tail()'
>
> Now, the code around it looks redundant. The '_init()' part of
> 'skb_queue_splice_tail_init()' should alreday do the same.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Un-tested
> ---
> net/sctp/ulpqueue.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
> index 877e55066f89..84d0fdaf7de9 100644
> --- a/net/sctp/ulpqueue.c
> +++ b/net/sctp/ulpqueue.c
> @@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc)
> * we can go ahead and clear out the lobby in one shot
> */
> if (!skb_queue_empty(&sp->pd_lobby)) {
> - struct list_head *list;
> skb_queue_splice_tail_init(&sp->pd_lobby,
> &sk->sk_receive_queue);
> - list = (struct list_head *)&sctp_sk(sk)->pd_lobby;
> - INIT_LIST_HEAD(list);
> return 1;
> }
> } else {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2016-09-07 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 9:38 [PATCH] sctp: Remove some redundant code Christophe JAILLET
2016-09-05 12:40 ` marcelo.leitner
2016-09-05 23:48 ` marcelo.leitner
2016-09-07 15:19 ` Neil Horman [this message]
2016-09-15 17:34 ` Marcelo
2016-09-15 19:32 ` Christophe JAILLET
2016-09-15 20:19 ` Marcelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907151942.GB21945@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).