From: Minchan Kim <minchan@kernel.org>
To: Andreas Mohr <andi@lisas.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC] zram: support page-based parallel write
Date: Thu, 8 Sep 2016 11:31:34 +0900 [thread overview]
Message-ID: <20160908023134.GA21691@bbox> (raw)
In-Reply-To: <20160906082220.GA2751@rhlx01.hs-esslingen.de>
Hello,
On Tue, Sep 06, 2016 at 10:22:20AM +0200, Andreas Mohr wrote:
> On Tue, Sep 06, 2016 at 04:24:17PM +0900, Minchan Kim wrote:
> > @@ -1464,6 +1908,9 @@ static int __init zram_init(void)
> > num_devices--;
> > }
> >
> > + if (create_workers())
> > + goto out_error;
> > +
> > return 0;
> >
> > out_error:
> > @@ -1474,6 +1921,7 @@ static int __init zram_init(void)
> > static void __exit zram_exit(void)
> > {
> > destroy_devices();
> > + destroy_workers();
> > }
>
>
> Asymmetry --> "BUG".
>
> ...right?
destory_workers checks workers list so if it's empty, it doesn
nothing. Anyway, I am chaning thread management model now so
it should be changed, too. :)
>
> (I have to admit that current implementation structure
> is not easy to follow,
> thus I'm not fully sure)
>
>
> Thanks for working in this important area!
Thanks for the interest.
next prev parent reply other threads:[~2016-09-08 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 7:24 [RFC] zram: support page-based parallel write Minchan Kim
2016-09-06 8:22 ` Andreas Mohr
2016-09-08 2:31 ` Minchan Kim [this message]
2016-09-08 1:34 ` Sergey Senozhatsky
2016-09-08 2:49 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908023134.GA21691@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andi@lisas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).