From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758044AbcIHIBR (ORCPT ); Thu, 8 Sep 2016 04:01:17 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33566 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbcIHIBO (ORCPT ); Thu, 8 Sep 2016 04:01:14 -0400 Date: Thu, 8 Sep 2016 10:01:11 +0200 From: Peter Zijlstra To: Srinivas Pandruvada Cc: rjw@rjwysocki.net, tglx@linutronix.de, mingo@redhat.com, bp@suse.de, x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, tim.c.chen@linux.intel.com Subject: Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing Message-ID: <20160908080111.GT10153@twins.programming.kicks-ass.net> References: <1472762024-88771-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1472762024-88771-3-git-send-email-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472762024-88771-3-git-send-email-srinivas.pandruvada@linux.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2016 at 01:33:38PM -0700, Srinivas Pandruvada wrote: > +++ b/kernel/sched/sched.h > @@ -532,6 +532,17 @@ struct dl_rq { > > #ifdef CONFIG_SMP > > +static inline bool sched_asym_prefer(int a, int b) > +{ > + return arch_asym_cpu_priority(a) > arch_asym_cpu_priority(b); > +} > + > +/* > + * Return lowest numbered cpu in the group as the most preferred cpu > + * for ASYM_PACKING for default case. > + */ > +#define group_priority_cpu(group) group->asym_prefer_cpu > + Both these are no longer used outside of sched/fair.c, and should probably be moved there. Also the later has no reason for being a macro.