From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941270AbcIHNGe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 09:06:34 -0400
Received: from mail.kernel.org ([198.145.29.136]:35706 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932299AbcIHNGc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 09:06:32 -0400
Date: Thu, 8 Sep 2016 21:05:49 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: shh.xie@gmail.com
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
        linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
        will.deacon@arm.com, linux-kernel@vger.kernel.org,
        Mihai Bantea <mihai.bantea@nxp.com>,
        Chenhui Zhao <chenhui.zhao@nxp.com>, arnd@arndb.de,
        Shaohui Xie <Shaohui.Xie@nxp.com>, Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
        Minghuan Lian <Minghuan.Lian@nxp.com>, Mingkai Hu <Mingkai.Hu@nxp.com>,
        Horia Geant? <horia.geanta@nxp.com>, Gong Qianyu <Qianyu.Gong@nxp.com>
Subject: Re: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support
Message-ID: <20160908130549.GA16911@tiger>
References: <1473069695-33092-1-git-send-email-shh.xie@gmail.com>
 <1473069695-33092-4-git-send-email-shh.xie@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1473069695-33092-4-git-send-email-shh.xie@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 05, 2016 at 06:01:31PM +0800, shh.xie@gmail.com wrote:
> +	soc {
> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		clockgen: clocking@1ee1000 {
> +			compatible = "fsl,ls1046a-clockgen";
> +			reg = <0x0 0x1ee1000 0x0 0x1000>;
> +			#clock-cells = <2>;
> +			clocks = <&sysclk>;
> +		};
> +
> +		scfg: scfg@1570000 {

Instead of having device node in arbitrary place, can we sort all the
nodes under 'simple-bus' in order of unit-address?

Shawn

> +			compatible = "fsl,ls1046a-scfg", "syscon";
> +			reg = <0x0 0x1570000 0x0 0x10000>;
> +			big-endian;
> +		};