From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbcIJBPm (ORCPT ); Fri, 9 Sep 2016 21:15:42 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34712 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbcIJBPj (ORCPT ); Fri, 9 Sep 2016 21:15:39 -0400 Date: Fri, 09 Sep 2016 18:15:36 -0700 (PDT) Message-Id: <20160909.181536.1766927673226492239.davem@davemloft.net> To: colin.king@canonical.com Cc: andrew.hendry@gmail.com, linux-x25@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: x25: remove null checks on arrays calling_ae and called_ae From: David Miller In-Reply-To: <20160908074206.13662-1-colin.king@canonical.com> References: <20160908074206.13662-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 09 Sep 2016 18:15:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 8 Sep 2016 08:42:06 +0100 > From: Colin Ian King > > dtefacs.calling_ae and called_ae are both 20 element __u8 arrays and > cannot be null and hence are redundant checks. Remove these. > > Signed-off-by: Colin Ian King Indeed, and if they were pointers they would be in userspace and would need proper uaccess handling. Applied to net-next, thanks.