From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbcIILMr (ORCPT ); Fri, 9 Sep 2016 07:12:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:58529 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754210AbcIILMo (ORCPT ); Fri, 9 Sep 2016 07:12:44 -0400 Date: Fri, 9 Sep 2016 13:11:05 +0200 From: David Sterba To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik , Jan Kara Subject: Re: linux-next: build failure after merge of the btrfs-kdave tree Message-ID: <20160909111105.GR16983@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik , Jan Kara References: <20160907112253.3bd54c49@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160907112253.3bd54c49@canb.auug.org.au> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07, 2016 at 11:22:53AM +1000, Stephen Rothwell wrote: > Hi David, > > After merging the btrfs-kdave tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > fs/ntfs/attrib.c: In function 'ntfs_attr_set': > fs/ntfs/attrib.c:2549:35: error: implicit declaration of function 'inode_to_bdi' [-Werror=implicit-function-declaration] > balance_dirty_pages_ratelimited(inode_to_bdi(inode), > ^ > fs/ntfs/attrib.c:2549:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion] > In file included from include/linux/memcontrol.h:30:0, > from include/linux/swap.h:8, > from fs/ntfs/attrib.c:26: > include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int' > void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi, > ^ > fs/ntfs/attrib.c:2591:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion] > balance_dirty_pages_ratelimited(inode_to_bdi(inode), > ^ > In file included from include/linux/memcontrol.h:30:0, > from include/linux/swap.h:8, > from fs/ntfs/attrib.c:26: > include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int' > void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi, > ^ > fs/ntfs/attrib.c:2609:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion] > balance_dirty_pages_ratelimited(inode_to_bdi(inode), > ^ > In file included from include/linux/memcontrol.h:30:0, > from include/linux/swap.h:8, > from fs/ntfs/attrib.c:26: > include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int' > void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi, > ^ > > Caused by commit > > a685fa61566d ("remove mapping from balance_dirty_pages*()") > > I assume some forgotten include(s). No, I picked a wrong version of the patchset. But the patchset should not have been in for-next as it's a change to writeback (a prerequisity for a btrfs patchset). Now removed.