From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752333AbcIIRKf (ORCPT ); Fri, 9 Sep 2016 13:10:35 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60304 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbcIIRKe (ORCPT ); Fri, 9 Sep 2016 13:10:34 -0400 Date: Fri, 9 Sep 2016 18:10:04 +0100 From: Mark Brown To: Binoy Jayan Cc: Thomas Gleixner , Carsten Emde , "Steven Rostedt (Red Hat)" , Ingo Molnar , Daniel Wagner , Arnd Bergmann , Linux kernel mailing list , Masami Message-ID: <20160909171004.GU27946@sirena.org.uk> References: <1473246835-30075-1-git-send-email-binoy.jayan@linaro.org> <1473246835-30075-5-git-send-email-binoy.jayan@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DFFMAMYvrfM3lt66" Content-Disposition: inline In-Reply-To: X-Cookie: Question authority. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DFFMAMYvrfM3lt66 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 08, 2016 at 03:09:36PM +0530, Binoy Jayan wrote: > On 8 September 2016 at 12:40, Thomas Gleixner wrote: > > On Wed, 7 Sep 2016, Binoy Jayan wrote: > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST > >> + ktime_t praecox; > >> +#endif > > And of course documenting new struct members is optional, correct? I'm > > really looking forward for the explanation of that variable name. > It marks the start time when a process is scheduled to be woken up as > the result > of expiry of the hrtimer. Will be mentioning it in the comments. Even with an appropriate comment I'm not sure that the term praecox is sufficiently widely understood to be a clear variable name. --DFFMAMYvrfM3lt66 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJX0uzrAAoJECTWi3JdVIfQnlwH/i7C/rUzuoUkaBO3vxnOL0sS g6dh8S4Qqo38vzdj1ki4BbS4jTjURL9LCWvNOvpCGuwsTYDCOkG6RBdHzXnYqy7D SWVxllMsKHeFOgXpEDDTeqFPcpH1xBGxE6BP5cy38yUEBV9rFT97PGy51gd9S5hs OAESpGtLnz9g8w8/fgq8dqaseN9v589i2pu4sGrXzRHuF4u66hSN8WQQ6O0uiQuO RjEZGc6DQ+BRNngY14m/XQ3sv2BBpDnARBqXncVtS8pF9I9rQzowILW7hmHYKJpi 1XD0cSidapeeVDmZ8iDkFvM51NCpvGco+eKF4Q7K0QeDSjiD9OTkWnLh49m0TL0= =VCPs -----END PGP SIGNATURE----- --DFFMAMYvrfM3lt66--