From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754337AbcIJJJ5 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 10 Sep 2016 05:09:57 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:34372 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751696AbcIJJJw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 10 Sep 2016 05:09:52 -0400
Date: Sat, 10 Sep 2016 11:09:46 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>, x86@kernel.org,
        Ingo Molnar <mingo@redhat.com>, Toshi Kani <toshi.kani@hpe.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Borislav Petkov <bp@suse.de>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Nathan Zimmer <nzimmer@sgi.com>,
        linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
        Daniel J Blueman <daniel@numascale.com>,
        Dimitri Sivanich <sivanich@sgi.com>,
        Matt Fleming <matt@codeblueprint.co.uk>, Hedi Berriche <hedi@sgi.com>,
        Steffen Persvold <sp@numascale.com>, Alex Thorlton <athorlton@sgi.com>,
        Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] x86: squash lines for simple wrapper functions
Message-ID: <20160910090946.GA28074@gmail.com>
References: <1473161053-10068-1-git-send-email-yamada.masahiro@socionext.com>
 <20160908063359.GB24253@gmail.com>
 <alpine.DEB.2.20.1609091639020.5679@nanos>
 <20160910043533.GB6061@gmail.com>
 <alpine.DEB.2.20.1609100752450.9305@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1609100752450.9305@nanos>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Sat, 10 Sep 2016, Ingo Molnar wrote:
> > * Thomas Gleixner <tglx@linutronix.de> wrote:
> > 
> > > On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > > > * Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> > > > >  static unsigned long set_apic_id(unsigned int id)
> > > > >  {
> > > > > -	unsigned long x;
> > > > > -
> > > > >  	/* maskout x2apic_extra_bits ? */
> > > > > -	x = id;
> > > > > -	return x;
> > > > > +	return id;
> > > > >  }
> > > > 
> > > > This was clearly left there to document a quirk and as a placeholder for future 
> > > > changes.
> > > 
> > > Keeping the comment and rewording it to:
> > > 
> > > 	/* CHECKME: Do we need to mask out the xapic extra bits */
> > > 
> > > should be good enough. The variable dance is not really giving any value.
> > 
> > Yeah, sure - my point was that the mindless removal is wrong.
> 
> He kept the comment. The rewording is a bonus.

Ok, fair enough.

Thanks,

	Ingo