From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753787AbcILQlm (ORCPT ); Mon, 12 Sep 2016 12:41:42 -0400 Received: from mail.skyhub.de ([78.46.96.112]:40682 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbcILQlh (ORCPT ); Mon, 12 Sep 2016 12:41:37 -0400 Date: Mon, 12 Sep 2016 18:41:33 +0200 From: Borislav Petkov To: Tom Lendacky Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Arnd Bergmann , Jonathan Corbet , Matt Fleming , Joerg Roedel , Konrad Rzeszutek Wilk , Andrey Ryabinin , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Paolo Bonzini , Alexander Potapenko , Thomas Gleixner , Dmitry Vyukov Subject: Re: [RFC PATCH v2 12/20] x86: Add support for changing memory encryption attribute Message-ID: <20160912164132.zmqef4ozbggt5ovh@pd.tnic> References: <20160822223529.29880.50884.stgit@tlendack-t1.amdoffice.net> <20160822223749.29880.10183.stgit@tlendack-t1.amdoffice.net> <20160909172314.ifcteua7nr52mzgs@pd.tnic> <4e423d15-7fe2-450a-05dd-1674bd281124@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4e423d15-7fe2-450a-05dd-1674bd281124@amd.com> User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 10:41:29AM -0500, Tom Lendacky wrote: > Looking at __change_page_attr_set_clr() isn't it possible for some of > the pages to be changed before an error is encountered since it is > looping? If so, we may still need to flush. The CPA_FLUSHTLB flag > should take care of a failing case where no attributes have actually > been changed. Ah, yes, ok, then yours is correct. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.