From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbcIMGxF (ORCPT ); Tue, 13 Sep 2016 02:53:05 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33875 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcIMGxE (ORCPT ); Tue, 13 Sep 2016 02:53:04 -0400 Date: Tue, 13 Sep 2016 08:53:01 +0200 From: Michal Hocko To: Andrew Morton Cc: linux-mm@kvack.org, LKML Subject: Re: [PATCH 1/2] fs: use mapping_set_error instead of opencoded set_bit Message-ID: <20160913065259.GA31898@dhcp22.suse.cz> References: <20160901091347.GC12147@dhcp22.suse.cz> <20160912111608.2588-1-mhocko@kernel.org> <20160912111608.2588-2-mhocko@kernel.org> <20160912151146.9999e6b1a9b18eac61d177d2@linux-foundation.org> <20160912151823.45d01e5acc44fa082c94dd2c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912151823.45d01e5acc44fa082c94dd2c@linux-foundation.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 12-09-16 15:18:23, Andrew Morton wrote: > On Mon, 12 Sep 2016 15:11:46 -0700 Andrew Morton wrote: > > > > @@ -409,7 +408,7 @@ static int afs_write_back_from_locked_page(struct afs_writeback *wb, > > > case -ENOMEDIUM: > > > case -ENXIO: > > > afs_kill_pages(wb->vnode, true, first, last); > > > - set_bit(AS_EIO, &wb->vnode->vfs_inode.i_mapping->flags); > > > + mapping_set_error(wb->vnode->vfs_inode.i_mapping, -ENXIO); > > > > This one is a functional change: mapping_set_error() will rewrite > > -ENXIO into -EIO. Doesn't seem at all important though. > > hm, OK, it's not a functional change - the code was already doing > s/ENXIO/EIO/. Yes the rewrite is silent but I've decided to keep the current errno because I have no idea whether this can change in future. It doesn't sound probable but it also sounds safer to do an overwrite at a single place rather than all over the place /me thinks. > Let's make it look more truthful? > > --- a/fs/afs/write.c~fs-use-mapping_set_error-instead-of-opencoded-set_bit-fix > +++ a/fs/afs/write.c > @@ -408,7 +408,7 @@ no_more: > case -ENOMEDIUM: > case -ENXIO: > afs_kill_pages(wb->vnode, true, first, last); > - mapping_set_error(wb->vnode->vfs_inode.i_mapping, -ENXIO); > + mapping_set_error(wb->vnode->vfs_inode.i_mapping, -EIO); > break; > case -EACCES: > case -EPERM: > _ > > -- Michal Hocko SUSE Labs