From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbcIMMkV (ORCPT ); Tue, 13 Sep 2016 08:40:21 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35695 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754413AbcIMMkS (ORCPT ); Tue, 13 Sep 2016 08:40:18 -0400 Date: Tue, 13 Sep 2016 13:42:15 +0100 From: Lee Jones To: Axel Lin Cc: Keerthy , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x Message-ID: <20160913124215.GC28894@dell> References: <1473123595-30475-1-git-send-email-axel.lin@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473123595-30475-1-git-send-email-axel.lin@ingics.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Sep 2016, Axel Lin wrote: > The mutex is not used, so remove it. > > Signed-off-by: Axel Lin > --- > drivers/mfd/lp873x.c | 2 -- > include/linux/mfd/lp873x.h | 1 - > 2 files changed, 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c > index 9af064c..873c608 100644 > --- a/drivers/mfd/lp873x.c > +++ b/drivers/mfd/lp873x.c > @@ -53,8 +53,6 @@ static int lp873x_probe(struct i2c_client *client, > return ret; > } > > - mutex_init(&lp873->lock); > - > ret = regmap_read(lp873->regmap, LP873X_REG_OTP_REV, &otpid); > if (ret) { > dev_err(lp873->dev, "Failed to read OTP ID\n"); > diff --git a/include/linux/mfd/lp873x.h b/include/linux/mfd/lp873x.h > index 83b1bd7..edbec83 100644 > --- a/include/linux/mfd/lp873x.h > +++ b/include/linux/mfd/lp873x.h > @@ -263,7 +263,6 @@ enum lp873x_regulator_id { > struct lp873x { > struct device *dev; > u8 rev; > - struct mutex lock; /* lock guarding the data structure */ > struct regmap *regmap; > }; > #endif /* __LINUX_MFD_LP873X_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog