From: Rob Herring <robh@kernel.org>
To: linshunquan 00354166 <linshunquan1@hisilicon.com>
Cc: mark.rutland@arm.com, lee.jones@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
howell.yang@hisilicon.com, xuejiancheng@hisilicon.com,
jalen.hsu@hisilicon.com, lvkuanliang@hisilicon.com,
suwenping@hisilicon.com, raojun@hisilicon.com,
kevin.lixu@hisilicon.com
Subject: Re: [PATCH] mfd: Add HiSilicon Flash Memory Controller(FMC) driver
Date: Tue, 13 Sep 2016 09:56:07 -0500 [thread overview]
Message-ID: <20160913145607.GA11998@rob-hp-laptop> (raw)
In-Reply-To: <1473130643-12310-1-git-send-email-linshunquan1@hisilicon.com>
On Tue, Sep 06, 2016 at 10:57:22AM +0800, linshunquan 00354166 wrote:
> From: Shunquan Lin <linshunquan1@hisilicon.com>
>
> This patch adds driver support for HiSilicon Flash Memory
> Controller(FMC). HiSilicon FMC is a multi-functions device which
> supports SPI Nor flash controller, SPI nand Flash controller and
> parallel nand flash controller.
>
> Signed-off-by: Shunquan Lin <linshunquan1@hisilicon.com>
> ---
> .../devicetree/bindings/mfd/hisilicon,hisi-fmc.txt | 54 ++++++++++
> drivers/mfd/Kconfig | 10 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/hisi_fmc.c | 109 +++++++++++++++++++++
> include/linux/mfd/hisi_fmc.h | 92 +++++++++++++++++
> 5 files changed, 266 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hisi-fmc.txt
> create mode 100644 drivers/mfd/hisi_fmc.c
> create mode 100644 include/linux/mfd/hisi_fmc.h
>
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hisi-fmc.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hisi-fmc.txt
> new file mode 100644
> index 0000000..cdaa0bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hisi-fmc.txt
> @@ -0,0 +1,54 @@
> +HiSilicon Flash Memory Controller
> +
> +The HiSilicon Flash Memory Controller(FMC) is a feature-rich controller
> +that supports SPI Nor, SPI Nand and Parallel Nand devices. This document
> +describes the binding for HiSilicon FMC device and its sub-notes.
> +
> +Required properties:
> +- compatible : Should be "hisilicon,hisi-fmc".
> +- reg : Offset and length of the register set for the controller device.
> +- reg-names : Must include the following two entries: "control", "memory".
> +- address-cells : Should be 1.
> +- size-cells : Should be 0.
> +- clocks : A phandle to the HiSilicon FMC controller clock.
> +
> +Optional sub-nodes:
> + - spi-nor:
> + Required properties:
> + - compatible : "hisilicon,fmc-spi-nor"
> + see "Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt
> +
> + - spi-nand:
> + Required properties:
> + - compatible : "hisilicon,fmc-spi-nand"
> + - reg : The chipselect for spi-nand devices
> + - address-cells : Should be 1.
> + - size-cells : Should be 0.
> +
> + - nand:
> + Required properties:
> + - compatible : "hisilicon,fmc-nand"
> + - reg : The chipselect for nand devices
> + - address-cells : Should be 1.
> + - size-cells : Should be 0.
> +
> +Example:
> +fmc: spi-nor-controller@10000000 {
> + compatible = "hisilicon,hisi-fmc";
> + reg = <0x10000000 0x1000>, <0x14000000 0x1000000>;
> + reg-names = "control", "memory";
> + clocks = <&crg FMC_CLK>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hisfc:spi-nor@0 {
> + compatible = "hisilicon,fmc-spi-nor";
Is this an actual h/w sub-block? If not remove this node and make the
spi-nor the immediate child.
> + #address-cells = <1>;
> + #size-cells = <0>;
> + hi_sfc {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + };
> + };
> +
> +};
next prev parent reply other threads:[~2016-09-13 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 2:57 [PATCH] mfd: Add HiSilicon Flash Memory Controller(FMC) driver linshunquan 00354166
2016-09-13 12:08 ` Lee Jones
2016-09-13 14:56 ` Rob Herring [this message]
[not found] ` <6b522be0-dcec-a84b-f161-69b8805bef62@hisilicon.com>
[not found] ` <CAL_Jsq+8qPYfiA_bojPP2vm6PGPr9B=ntct=OyhoJTervMZMuA@mail.gmail.com>
2016-10-10 3:19 ` linshunquan (A)
2016-10-17 8:03 ` linshunquan (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913145607.GA11998@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=howell.yang@hisilicon.com \
--cc=jalen.hsu@hisilicon.com \
--cc=kevin.lixu@hisilicon.com \
--cc=lee.jones@linaro.org \
--cc=linshunquan1@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvkuanliang@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=raojun@hisilicon.com \
--cc=suwenping@hisilicon.com \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).