From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759132AbcIMRiZ (ORCPT ); Tue, 13 Sep 2016 13:38:25 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.217]:24849 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753968AbcIMRiX (ORCPT ); Tue, 13 Sep 2016 13:38:23 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWtqWFmrC5F/k8792brrkQ== X-RZG-CLASS-ID: mo00 Date: Tue, 13 Sep 2016 19:38:16 +0200 From: Olaf Hering To: kys@microsoft.com Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, alexng@microsoft.com, Alex Ng Subject: Re: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples. Message-ID: <20160913173816.GA29448@aepfle.de> References: <1473337400-6050-1-git-send-email-kys@exchange.microsoft.com> <1473337454-6097-1-git-send-email-kys@exchange.microsoft.com> <1473337454-6097-3-git-send-email-kys@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <1473337454-6097-3-git-send-email-kys@exchange.microsoft.com> User-Agent: Mutt/1.6.2 (6759) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Thu, Sep 08, kys@exchange.microsoft.com wrote: > - default: > + case(VERSION_WIN10): > util_fw_version = UTIL_FW_VERSION; > sd_srv_version = SD_VERSION; > ts_srv_version = TS_VERSION; > hb_srv_version = HB_VERSION; > + break; > + default: > + util_fw_version = UTIL_FW_VERSION; > + sd_srv_version = SD_VERSION; > + ts_srv_version = TS_VERSION_3; > + hb_srv_version = HB_VERSION; Is this correct? An old kernel on a newer host would use the old protocol. I assume that new host will also know about the old protocol? Perhaps a better approach would be to list the known existing hosts and use the new protocol for upcoming, unknown hosts via 'default:'. Olaf --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlfYOYQACgkQXUKg+qaYNn6a3ACgg4xLhkszL5uMnQ0feRnupB6N Y5EAoOiqnd5uSX8kAj59seuJi63cM6M9 =7ozF -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--