From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761147AbcINIm0 (ORCPT ); Wed, 14 Sep 2016 04:42:26 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:49913 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754132AbcINImU (ORCPT ); Wed, 14 Sep 2016 04:42:20 -0400 From: Arnd Bergmann To: Lee Jones , Thomas Gleixner Cc: Arnd Bergmann , "Andrew F. Davis" , Marc Zyngier , Daniel Lezcano , linux-kernel@vger.kernel.org Subject: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Date: Wed, 14 Sep 2016 10:22:05 +0200 Message-Id: <20160914084202.1032264-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:3VNCHjcp+ZQdvgoNo0RxtP/2S/uPgWD9qazU7lW41nCLkKhKO8s 6oHuCqspfcV9SN73DLjdGpg4RsgZ6Ogus+1cl/GdA7rlrtSZDpAFQ5ymG809e0PollOtwfl n2Aak54+spwSRdcAiOX6fpI2hU9OR1rK+qC99hwNsrbG1LDjKPDqBXE/bofqKOr0rC5ASLM 9dcP5LGhbyWY/SsbTz9vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:C7iQWvRCcaI=:bAmR6c2LZcU2j0BZ9Ytv7Z 3dxP712bG5Ta4A6gU8Jl2CaK80LTVJ6La1/hS8nARESzjzCFimipTmthqkRNhZbq1OBBe2lO8 Sdsl6RNaDNjDbLfd5e04cl+D+BuIwgyMvFFqFRRXWW6TXbcdnSOpZZXuujCA5INof+HZa0KUB Y/QxLVu1Nm2476TdHti4oNpzziZGh0Dpw+lZ4g8eaboMfML+b+Jie0El8CikwhhnaYz1Icxxc a6Y6pBXhpTdF2dCZ5bKTfXpjfmQtU/edUNhFH6gImzNcu/DtpRZ2xyVTL9IGixji+mOQl3JMG YSuLzpatt1FdguAYxT/I7H9WZRMRD9//hp49agPPXt6ysPvrTziAPScEj4Y7IJJEs0wNv2l2H VrEUN8bQ3irLwk3gB17Y6QROuxpRawKMI6iuLpOkDNzoWmlBCYM84/QWocsF40HWNASqwQZig Cknsrq8BnSMfBwtRPi1jE2q3kCvGOQgGhCPwv3BEGJ5hygaoKRToHxyp1ARtcNVIbWJQVVu7T kuTGvT20D0szHZzLi91eoJnUsEeAkG3v4a+Bbe3FML8akKeq7UnYaDDcR3a2+CepGb7kESVdr SxPVyU0qqRMZlVUtIFt1Ezv4WYK1j1rzQhadrk2b+NlvlqnRIOroc6/kht+Z8NkD0FK9dW72s 5WoWSATHmaUCBK+bZNXNQYKyYVgJ8As7dPeCAK35tinqUAe9srmn7zhlsOZNporI8ayc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building tps65217 as a loadable module (as done in allmodconfig) now fails after we started calling irq_set_parent(): ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined! The two obvious workarounds are either to force the driver to be built-in, or to make that symbol exported to modules. As it's not clear to me if either of them would be acceptable, I'm sending both of them here, please comment on which one you want to have, or whether the driver should handle this differently and not call irq_set_parent() at all. Signed-off-by: Arnd Bergmann Fixes: 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs") --- drivers/mfd/Kconfig | 2 +- kernel/irq/manage.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index be1945a42dd1..9a4cef5a2ece 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1229,7 +1229,7 @@ config MFD_TPS65090 functionality of the device. config MFD_TPS65217 - tristate "TI TPS65217 Power Management / White LED chips" + bool "TI TPS65217 Power Management / White LED chips" depends on I2C select MFD_CORE select REGMAP_I2C diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 0c5f1a5db654..9c4d30483264 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -721,6 +721,7 @@ int irq_set_parent(int irq, int parent_irq) irq_put_desc_unlock(desc, flags); return 0; } +EXPORT_SYMBOL_GPL(irq_set_parent); #endif /* -- 2.9.0