From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759777AbcINJ2Y (ORCPT ); Wed, 14 Sep 2016 05:28:24 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49445 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755494AbcINJ2W (ORCPT ); Wed, 14 Sep 2016 05:28:22 -0400 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: naveen.n.rao@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 14 Sep 2016 14:58:10 +0530 From: "Naveen N. Rao" To: Arnaldo Carvalho de Melo Cc: Wang Nan , linux-kernel@vger.kernel.org, lizefan@huawei.com, pi3orama@163.com Subject: Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture References: <1473684871-209320-1-git-send-email-wangnan0@huawei.com> <1473684871-209320-2-git-send-email-wangnan0@huawei.com> <20160912190742.GG4897@kernel.org> <20160912211520.GA10582@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160912211520.GA10582@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091409-0052-0000-0000-000001C79B0E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091409-0053-0000-0000-000006C865DD Message-Id: <20160914092810.GA21691@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-14_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609140129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Sep 12, 2016 at 12:54:29PM +0000, Wang Nan escreveu: > > > Some mmap related macros have different values for different > > > architectures. This patch introduces uapi mman.h for each > > > architectures. > > > > > > Three headers are cloned from kernel include to tools/include: > > > > > > tools/include/uapi/asm-generic/mman-common.h > > > tools/include/uapi/asm-generic/mman.h > > > tools/include/uapi/linux/mman.h > > > > Cool, the above was done as copies, why not the rest? IIRC you mentioned > > some reasoning behind that decision, but we need it spelled out here. > > > > For instance, I went on and look at arch/xtensa/include/uapi/asm/mman.h, > > and couldn't find why we shouldn't copy it just like the three files > > above. > > > > I'm looking now at why the build breaks in so many systems, first hunch > > is that bits/ part (the ones without the failure details probably have > > the same errors), alpine uses musl libc, but some that broke are glibc > > based. > > So, please take a look at my perf/core branch, I applied 1/3 and 3/3, > but took a different path for 2/3, now it builds for all systems I have > containers for: This still fails for me on ppc64. Perhaps we should guard P_MMAP_FLAG(32BIT) and potentially others with a #ifdef, which was earlier reverted by commit 256763b0 ("perf trace beauty mmap: Add more conditional defines")? - Naveen --- In file included from builtin-trace.c:560:0: trace/beauty/mmap.c: In function ‘syscall_arg__scnprintf_mmap_flags’: trace/beauty/mmap.c:38:14: error: ‘MAP_32BIT’ undeclared (first use in this function) if (flags & MAP_##n) { \ ^ trace/beauty/mmap.c:45:2: note: in expansion of macro ‘P_MMAP_FLAG’ P_MMAP_FLAG(32BIT); ^ trace/beauty/mmap.c:38:14: note: each undeclared identifier is reported only once for each function it appears in if (flags & MAP_##n) { \ ^ trace/beauty/mmap.c:45:2: note: in expansion of macro ‘P_MMAP_FLAG’ P_MMAP_FLAG(32BIT); ^ CC bench/mem-functions.o mv: cannot stat ‘./.builtin-trace.o.tmp’: No such file or directory make[2]: *** [builtin-trace.o] Error 1 make[2]: *** Waiting for unfinished jobs....