From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762889AbcINNwg (ORCPT ); Wed, 14 Sep 2016 09:52:36 -0400 Received: from mail.kernel.org ([198.145.29.136]:47870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762704AbcINNwX (ORCPT ); Wed, 14 Sep 2016 09:52:23 -0400 Date: Wed, 14 Sep 2016 10:52:13 -0300 From: Arnaldo Carvalho de Melo To: "Naveen N. Rao" Cc: Wang Nan , linux-kernel@vger.kernel.org, lizefan@huawei.com, pi3orama@163.com Subject: Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture Message-ID: <20160914135213.GA9849@kernel.org> References: <1473684871-209320-1-git-send-email-wangnan0@huawei.com> <1473684871-209320-2-git-send-email-wangnan0@huawei.com> <20160912190742.GG4897@kernel.org> <20160912211520.GA10582@kernel.org> <20160914092810.GA21691@naverao1-tp.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160914092810.GA21691@naverao1-tp.localdomain> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 14, 2016 at 02:58:10PM +0530, Naveen N. Rao escreveu: > On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote: > > Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo escreveu: > > So, please take a look at my perf/core branch, I applied 1/3 and 3/3, > > but took a different path for 2/3, now it builds for all systems I have > > containers for: > This still fails for me on ppc64. Perhaps we should guard > P_MMAP_FLAG(32BIT) and potentially others with a #ifdef, which was > earlier reverted by commit 256763b0 ("perf trace beauty mmap: Add more > conditional defines")? Humm, yeah, we have to find a way to make it clear that some flags are not present in all arches, I'll think about the solution Wang came up with, i.e. having it defined to zero on arches where it is not supported, which at first sounds ugly :-\ One thing related to this, but for future work, is to be able to support doing a ' perf trace record' on x86_64 and then doing a 'perf trace -i perf.data' with the resulting file, i.e. cross-platform syscall arg beautifying, i.e. a cross-arch strace. Right now we use audit lib to at least map the syscall ids using, IIRC, the header env stuff, but we need to go to the syscall args as well. Future work, sure. And yeah, I'll try and cross-build audit-lib for my powerpc cross build containers, so that I can catch this bug before applying these patches and make sure things like this get caught in the future. - Arnaldo > - Naveen > > --- > In file included from builtin-trace.c:560:0: > trace/beauty/mmap.c: In function ‘syscall_arg__scnprintf_mmap_flags’: > trace/beauty/mmap.c:38:14: error: ‘MAP_32BIT’ undeclared (first use in this function) > if (flags & MAP_##n) { \ > ^ > trace/beauty/mmap.c:45:2: note: in expansion of macro ‘P_MMAP_FLAG’ > P_MMAP_FLAG(32BIT); > ^ > trace/beauty/mmap.c:38:14: note: each undeclared identifier is reported only once for each function it appears in > if (flags & MAP_##n) { \ > ^ > trace/beauty/mmap.c:45:2: note: in expansion of macro ‘P_MMAP_FLAG’ > P_MMAP_FLAG(32BIT); > ^ > CC bench/mem-functions.o > mv: cannot stat ‘./.builtin-trace.o.tmp’: No such file or directory > make[2]: *** [builtin-trace.o] Error 1 > make[2]: *** Waiting for unfinished jobs....