From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762189AbcINNzx (ORCPT ); Wed, 14 Sep 2016 09:55:53 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33010 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758363AbcINNzu (ORCPT ); Wed, 14 Sep 2016 09:55:50 -0400 Date: Wed, 14 Sep 2016 15:55:35 +0200 From: Richard Cochran To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Mugunthan V N , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, WingMan Kwok Subject: Re: [PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver Message-ID: <20160914135535.GB28592@localhost.localdomain> References: <20160914130231.3035-1-grygorii.strashko@ti.com> <20160914130231.3035-5-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160914130231.3035-5-grygorii.strashko@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 04:02:26PM +0300, Grygorii Strashko wrote: > Move DT properties parsing into CPTS driver to simplify consumer's > code and CPTS driver porting on other SoC in the future > (like Keystone 2). And just who is the consumer? > Signed-off-by: Grygorii Strashko > --- > drivers/net/ethernet/ti/cpsw.c | 16 +--------------- > drivers/net/ethernet/ti/cpsw.h | 2 -- > drivers/net/ethernet/ti/cpts.c | 29 ++++++++++++++++++++++++++--- > drivers/net/ethernet/ti/cpts.h | 5 +++-- > 4 files changed, 30 insertions(+), 22 deletions(-) You have more (+) than (-). I wouldn't call that a simplification. Thanks, Richard