From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbcIOQQd (ORCPT ); Thu, 15 Sep 2016 12:16:33 -0400 Received: from mga14.intel.com ([192.55.52.115]:17623 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbcIOQQa (ORCPT ); Thu, 15 Sep 2016 12:16:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,339,1470726000"; d="scan'208";a="1050948726" Date: Thu, 15 Sep 2016 21:54:49 +0530 From: Vinod Koul To: Sam Van Den Berge Cc: Sylwester Nawrocki , dmaengine@vger.kernel.org, k.kozlowski@samsung.com, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices Message-ID: <20160915162449.GY13920@localhost> References: <1473877775-7537-1-git-send-email-sam.van.den.berge@telenet.be> <2fa402bf-0e3f-0495-41ca-7a3c89eaa2e1@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fa402bf-0e3f-0495-41ca-7a3c89eaa2e1@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 11:05:12AM +0200, Sylwester Nawrocki wrote: > On 09/14/2016 08:29 PM, Sam Van Den Berge wrote: > > +static const struct dma_slave_map s3c2440_dma_slave_map[] = { > ... > > + { "3c2440-sdi", "rx", (void *)DMACH_SDI }, > > + { "3c2440-sdi", "tx", (void *)DMACH_SDI }, > > The device names seem misspelled here, and looking at what > drivers/mmc/host/s3cmci.c driver does we need just a single common > entry for rx and tx > > { "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI }, > > With this fixed feel free to add And please change the title to dmaengine and NOT arm... I was about ti skip this! -- ~Vinod