From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758317AbcIPIdr (ORCPT ); Fri, 16 Sep 2016 04:33:47 -0400 Received: from verein.lst.de ([213.95.11.211]:59442 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754243AbcIPIdf (ORCPT ); Fri, 16 Sep 2016 04:33:35 -0400 Date: Fri, 16 Sep 2016 10:33:33 +0200 From: Christoph Hellwig To: Andy Lutomirski Cc: Keith Busch , Jens Axboe , linux-nvme@lists.infradead.org, Christoph Hellwig , linux-kernel@vger.kernel.org, J Freyensee Subject: Re: [PATCH v3 1/3] nvme/scsi: Remove power management support Message-ID: <20160916083333.GB2415@lst.de> References: <714df91022b06c6799afb315962769f22b8ab9f4.1474002926.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <714df91022b06c6799afb315962769f22b8ab9f4.1474002926.git.luto@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote: > As far as I can tell, there is basically nothing correct about this > code. It misinterprets npss (off-by-one). It hardcodes a bunch of > power states, which is nonsense, because they're all just indices > into a table that software needs to parse. It completely ignores > the distinction between operational and non-operational states. > And, until 4.8, if all of the above magically succeeded, it would > dereference a NULL pointer and OOPS. > > Since this code appears to be useless, just delete it. Yes, please! Acked-by: Christoph Hellwig