From: Mark Rutland <mark.rutland@arm.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
james.morse@arm.com, Kees Cook <keescook@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
lorenzo.pieralisi@arm.com, Andrew Lutomirski <luto@kernel.org>,
suzuki.poulose@arm.com,
Takahiro Akashi <takahiro.akashi@linaro.org>,
Will Deacon <will.deacon@arm.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info
Date: Fri, 16 Sep 2016 11:33:26 +0100 [thread overview]
Message-ID: <20160916103101.GA21702@leverpostej> (raw)
In-Reply-To: <CALCETrWni0aZ71r-R6oYG98kZvZA8a184UR0YURk_=tXu8HXMw@mail.gmail.com>
On Thu, Sep 15, 2016 at 11:37:47AM -0700, Andy Lutomirski wrote:
> On Thu, Sep 15, 2016 at 6:49 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > Currently, task_struct is defined in <linux/sched.h>, which (indirectly)
> > pulls in a number of low-level arch headers such as <asm/preempt.h>
> > through a number of other headers. Thus, code and structures in these
> > headers can't rely on the definition of task_struct. Some of these
> > headers are necessary for the definition of task_struct, so moving
> > task_struct into its own header is insufficient tio avoid circular
> > includes.
>
> The flippant answer is to fix the headers, but I tried that myself and
> gave up :(
Agreed; likewise (though I gave up quicker, I suspect). :(
Longer-term I'd still hope that we can do this.
> But how about this slightly less duplicative alternative:
>
> struct thread_info {
> #ifdef arch_thread_info
> struct arch_thread_info arch_ti;
> #endif
> };
I'm happy to have an arch_thread_info.
Just to check, what do you mean to happen with the flags field? Should
that always be in the generic thread_info? e.g.
struct thread_info {
u32 flags;
#ifdef arch_thread_info
struct arch_thread_info arch_ti;
#endif
};
Thanks,
Mark,
next prev parent reply other threads:[~2016-09-16 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:49 [RFC PATCH 0/8] arm64: move thread_info off of the task stack Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 1/8] thread_info: include <current.h> for THREAD_INFO_IN_TASK Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Mark Rutland
2016-09-15 18:37 ` Andy Lutomirski
2016-09-16 10:33 ` Mark Rutland [this message]
2016-09-16 15:11 ` Andy Lutomirski
2016-09-19 10:44 ` Mark Rutland
2016-09-21 10:28 ` Mark Rutland
2016-09-22 22:23 ` Andy Lutomirski
2016-09-23 17:31 ` Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 3/8] arm64: thread_info remove stale items Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 4/8] arm64: asm-offsets: remove unused definitions Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 5/8] arm64: assembler: introduce ldr_this_cpu Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 6/8] arm64: traps: use task_struct instead of thread_info Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 7/8] arm64: move sp_el0 and tpidr_el1 into cpu_suspend_ctx Mark Rutland
2016-09-15 13:49 ` [RFC PATCH 8/8] arm64: split thread_info from task stack Mark Rutland
2016-09-21 1:26 ` [RFC PATCH 0/8] arm64: move thread_info off of the " Laura Abbott
2016-09-21 10:31 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916103101.GA21702@leverpostej \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).