From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765095AbcIPNQa (ORCPT ); Fri, 16 Sep 2016 09:16:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38609 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756624AbcIPNQX (ORCPT ); Fri, 16 Sep 2016 09:16:23 -0400 Date: Fri, 16 Sep 2016 15:16:20 +0200 From: Boris Brezillon To: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, Boris Brezillon , Richard Weinberger Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: Fix nand_command_lp() for 8bits opcodes Message-ID: <20160916151620.0572d21d@bbrezillon> In-Reply-To: <1465988991-1220-1-git-send-email-boris.brezillon@free-electrons.com> References: <1465988991-1220-1-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jun 2016 13:09:51 +0200 Boris Brezillon wrote: > 8 bits opcodes should be followed by a single address cycle. Make the > 2nd address cycle dependent of !nand_opcode_8bits(command). Applied. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/nand_base.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 0b0dc29..c2f83236 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -745,7 +745,10 @@ static void nand_command_lp(struct mtd_info *mtd, unsigned int command, > column >>= 1; > chip->cmd_ctrl(mtd, column, ctrl); > ctrl &= ~NAND_CTRL_CHANGE; > - chip->cmd_ctrl(mtd, column >> 8, ctrl); > + > + /* Only ouput a single addr cycle for 8bits opcodes. */ > + if (!nand_opcode_8bits(command)) > + chip->cmd_ctrl(mtd, column >> 8, ctrl); > } > if (page_addr != -1) { > chip->cmd_ctrl(mtd, page_addr, ctrl);