From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935768AbcIPP2s (ORCPT ); Fri, 16 Sep 2016 11:28:48 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35495 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934589AbcIPP2k (ORCPT ); Fri, 16 Sep 2016 11:28:40 -0400 Date: Fri, 16 Sep 2016 10:28:38 -0500 From: Rob Herring To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Neil Armstrong , khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Message-ID: <20160916152838.GA6795@rob-hp-laptop> References: <1473321206-32284-1-git-send-email-narmstrong@baylibre.com> <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2016 at 02:50:37PM +0200, Andreas Färber wrote: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: > > Am 08.09.2016 um 09:53 schrieb Neil Armstrong: > >> This patchset adds a specific compatible string in the Meson SPIFC driver for > >> the Amlogic Meson GXBB SoC. > > > > Any particular reason? We could just reuse the meson6 one since there > > appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) New chip, always define a new compatible. If you think they are the same or are close enough to function with the existing driver, then put both compatible strings in the DT. Rob