From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936062AbcIPTlK (ORCPT ); Fri, 16 Sep 2016 15:41:10 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35030 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933663AbcIPTlD (ORCPT ); Fri, 16 Sep 2016 15:41:03 -0400 Date: Fri, 16 Sep 2016 14:41:01 -0500 From: Rob Herring To: Zach Brown Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, mark.rutland@arm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 1/2] sdhci-of-arasan: Add device tree parameter xlnx-fails-without-test-cd bit Message-ID: <20160916194101.GA3161@rob-hp-laptop> References: <1473363766-12652-1-git-send-email-zach.brown@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473363766-12652-1-git-send-email-zach.brown@ni.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2016 at 02:42:45PM -0500, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the CD bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function without the CD bit. > > The device property "xlnx-fails-without-test-cd" will let the arasan > driver know the controller does not have the CD line wired and that the > controller does not function without it. > > Signed-off-by: Zach Brown > --- > v2: > * improved commit messages > * removed fake-cd device property > * removed fake-cd quirk > * use broken-cd device property > * documented new usage of broken-cd > v3: > * removed new usage of broken-cd > * created fails-without-test-cd device property > * created arasan controller specific quirk > v4: > * changed fails-without-test-cd to xlnx-fails-without-test-cd > * removed extra blank line > v5: > * Fixed style mistake > * Changed (1 << 0 ) to BIT(0) > v6: > * Fixed style mistakes > * Condensed unnecessarily long variable names > * Removed line wraps that were no longer necessary. > * Rebased changes off Ulf's mmc tree's next branch. > > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > df --gt /Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 3404afa..e71f043 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -21,6 +21,10 @@ Required Properties: > - interrupts: Interrupt specifier > - interrupt-parent: Phandle for the interrupt controller that services > interrupts for this device. > +Optional Properties: > +- xlnx-fails-without-test-cd: when present, the controller doesn't work when xlnx,fails... With that, Acked-by: Rob Herring