From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755693AbcIQExt (ORCPT ); Sat, 17 Sep 2016 00:53:49 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35383 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbcIQExj (ORCPT ); Sat, 17 Sep 2016 00:53:39 -0400 Date: Sat, 17 Sep 2016 10:15:32 +0530 From: maitysanchayan@gmail.com To: Marcel Ziswiler Cc: "shawnguo@kernel.org" , "stefan@agner.ch" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Message-ID: <20160917044532.GA5729@Sanchayan-Arch.localdomain> References: <9d2c17aa2e00e6ff4349a53de8247860d2382607.1473833908.git.maitysanchayan@gmail.com> <1474033134.3103.27.camel@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1474033134.3103.27.camel@toradex.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Marcel, On 16-09-16 13:38:54, Marcel Ziswiler wrote: > On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote: > > Use enable-gpios property of PWM backlight driver for backlight > > control. While at it also fix the use of brightness levels required > > by EDT displays which require inverted PWM's. > > That part I am missing below. Did you forget to include it? No, actually I missed fixing the commit message. Currently PWM polarity inversion is not supported and while checking, I kept the brightness levels as is currently but did not change the commit message. Will send a v2 and fix this. Regards, Sanchayan. > > > Signed-off-by: Sanchayan Maity > > --- > >  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++ > >  1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > > index 8c67dd8..9100bde 100644 > > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > > @@ -49,7 +49,10 @@ > >   > >   backlight: backlight { > >   compatible = "pwm-backlight"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio_bl_on>; > >   pwms = <&pwm4 0 5000000>; > > + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; > >   status = "disabled"; > >   }; > >   > > @@ -614,6 +617,12 @@ > >   >; > >   }; > >   > > + pinctrl_gpio_bl_on: gpioblon { > > + fsl,pins = < > > + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0 > > + >; > > + }; > > + > >   pinctrl_gpio_keys: gpio1io04grp { > >   fsl,pins = < > >   /* Power button */