From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
wangnan0@huawei.com, sukadev@linux.vnet.ibm.com
Subject: Re: [PATCH] perf, tools: Handle events including .c and .o
Date: Sun, 18 Sep 2016 11:03:27 +0200 [thread overview]
Message-ID: <20160918090327.GA10394@krava> (raw)
In-Reply-To: <1474160566-8955-1-git-send-email-andi@firstfloor.org>
On Sat, Sep 17, 2016 at 06:02:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> This is a generic bug fix, but it helps with Sukadev's JSON event tree
> where such events can happen.
>
> Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading
> and then an error. This can happen for some Intel JSON events, which cannot
> be used.
>
> Fix the scanner to only match for .o or .c or .bpf at the end.
> This will prevent loading multiple BPF scripts separated with comma,
> but I assume this is acceptable.
>
> Cc: wangnan0@huawei.com
> Cc: sukadev@linux.vnet.ibm.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/util/parse-events.l | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 7a2519435da0..64ca26e4ed2d 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -162,8 +162,8 @@ modifier_bp [rwx]{1,3}
> }
>
> {event_pmu} |
> -{bpf_object} |
> -{bpf_source} |
> +({bpf_object}$) |
> +({bpf_source}$) |
why are the () braces necessary? anyway:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> {event} {
> BEGIN(INITIAL);
> REWIND(1);
> --
> 2.5.5
>
next prev parent reply other threads:[~2016-09-18 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 1:02 [PATCH] perf, tools: Handle events including .c and .o Andi Kleen
2016-09-18 9:03 ` Jiri Olsa [this message]
2016-09-18 14:52 ` Andi Kleen
2016-09-18 10:20 ` Wangnan (F)
2016-09-18 14:56 ` Andi Kleen
2016-09-19 2:50 ` Wangnan (F)
2016-10-06 20:18 [PATCH 1/3] " Arnaldo Carvalho de Melo
2016-10-08 4:16 ` [PATCH] " Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918090327.GA10394@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).