From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938868AbcISNp6 (ORCPT ); Mon, 19 Sep 2016 09:45:58 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:52099 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756055AbcISNpw (ORCPT ); Mon, 19 Sep 2016 09:45:52 -0400 Date: Mon, 19 Sep 2016 15:45:48 +0200 From: Andrew Lunn To: John Crispin Cc: "David S. Miller" , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] net-next: dsa: set_addr should be optional Message-ID: <20160919134548.GB8651@lunn.ch> References: <1474291683-44167-1-git-send-email-john@phrozen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474291683-44167-1-git-send-email-john@phrozen.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2016 at 03:27:59PM +0200, John Crispin wrote: > The Marvell driver is the only one that actually sets the switches HW > address. All other drivers have an empty stub. fix this by making the > callback optional. Hi John Thanks for doing this, Reviewed-by: Andrew Lunn Andrew