From: Krzysztof Kozlowski <krzk@kernel.org>
To: Randy Li <ayaka@soulik.info>
Cc: alsa-devel@alsa-project.org, sbkim73@samsung.com,
s.nawrocki@samsung.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: make audio interface/controller explicitly
Date: Mon, 19 Sep 2016 18:37:09 +0200 [thread overview]
Message-ID: <20160919163709.GA5981@kozik-book> (raw)
In-Reply-To: <1474300318-26767-1-git-send-email-ayaka@soulik.info>
On Mon, Sep 19, 2016 at 11:51:58PM +0800, Randy Li wrote:
> It is simple sound card time, we could assign different codec
> to a interface without making a specific driver for it. The SPDIF
> and I2S interface for Samsung would be possible used by simple-sound-card,
> but not sure about the PCM.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
> sound/soc/samsung/Kconfig | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
> index 7b722b0..210ce38 100644
> --- a/sound/soc/samsung/Kconfig
> +++ b/sound/soc/samsung/Kconfig
> @@ -1,3 +1,7 @@
> +menu "SoC Audio for Samsung CPUs"
This adds a new empty layer. One have to choose this menu and then
SND_SOC_SAMSUNG to access specific options. Instead of new menu, the
SND_SOC_SAMSUNG should be menuconfig. The existing "depends on" and the
one you added below won't be needed then, I think. Just have to be sure
that nothing selects particular drivers without selecting
SND_SOC_SAMSUNG first.
Best regards,
Krzysztof
> +
> +comment "Common SoC Audio options for Samsung CPUs:"
> +
> config SND_SOC_SAMSUNG
> tristate "ASoC support for Samsung"
> depends on (PLAT_SAMSUNG || ARCH_EXYNOS)
> @@ -18,18 +22,22 @@ config SND_S3C2412_SOC_I2S
> select SND_S3C_I2SV2_SOC
>
> config SND_SAMSUNG_PCM
> - tristate
> + tristate "Samsung PCM interface support"
> + depends on SND_SOC_SAMSUNG
>
> config SND_SAMSUNG_AC97
> tristate
> select SND_SOC_AC97_BUS
> + depends on SND_SOC_SAMSUNG
>
> config SND_SAMSUNG_SPDIF
> - tristate
> + tristate "Samsung SPDIF transmitter support"
> + depends on SND_SOC_SAMSUNG
> select SND_SOC_SPDIF
>
> config SND_SAMSUNG_I2S
> - tristate
> + tristate "Samsung I2S interface support"
> + depends on I2C && SND_SOC_SAMSUNG
>
> config SND_SOC_SAMSUNG_NEO1973_WM8753
> tristate "Audio support for Openmoko Neo1973 Smartphones (GTA02)"
> @@ -229,3 +237,5 @@ config SND_SOC_ARNDALE_RT5631_ALC5631
> depends on SND_SOC_SAMSUNG && I2C
> select SND_SAMSUNG_I2S
> select SND_SOC_RT5631
> +
> +endmenu
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-09-19 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 15:51 [PATCH] ASoC: samsung: make audio interface/controller explicitly Randy Li
2016-09-19 16:37 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-18 14:09 [PATCH] make samsung interface entries explicitly Randy Li
2016-09-18 14:09 ` [PATCH] ASoC: samsung: make audio interface/controller explicitly Randy Li
2016-09-18 14:42 ` Krzysztof Kozlowski
2016-09-18 15:12 ` ayaka
2016-09-18 18:09 ` Krzysztof Kozlowski
2016-09-19 1:21 ` Ayaka
2016-09-19 15:15 ` Krzysztof Kozlowski
2016-09-18 17:27 ` kbuild test robot
2016-09-19 1:42 ` kbuild test robot
2016-09-19 8:33 ` Mark Brown
2016-09-19 9:41 ` Ayaka
2016-09-19 10:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919163709.GA5981@kozik-book \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ayaka@soulik.info \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).