From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752511AbcITUKL (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Sep 2016 16:10:11 -0400
Received: from foss.arm.com ([217.140.101.70]:35552 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751729AbcITUKJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Sep 2016 16:10:09 -0400
Date: Tue, 20 Sep 2016 15:10:07 -0500
From: Kim Phillips <kim.phillips@arm.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Don Zickus <dzickus@redhat.com>,
        Joe Mario <jmario@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 47/61] perf c2c report: Add cacheline browser
Message-Id: <20160920151007.ad88298262bc99a968c95cd5@arm.com>
In-Reply-To: <1474290610-23241-48-git-send-email-jolsa@kernel.org>
References: <1474290610-23241-1-git-send-email-jolsa@kernel.org>
        <1474290610-23241-48-git-send-email-jolsa@kernel.org>
Organization: ARM
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 19 Sep 2016 15:09:56 +0200
Jiri Olsa <jolsa@kernel.org> wrote:

> +	/* reset abort key so that it can get Ctrl-C as a key */
> +	SLang_reset_tty();
> +	SLang_init_tty(0, 0, 0);

this fails to build on systems without slang:

  CC       builtin-c2c.o
builtin-c2c.c: In function ‘perf_c2c__browse_cacheline’:
builtin-c2c.c:2211:2: error: implicit declaration of function ‘SLang_reset_tty’ [-Werror=implicit-function-declaration]
  SLang_reset_tty();
  ^
builtin-c2c.c:2211:2: error: nested extern declaration of ‘SLang_reset_tty’ [-Werror=nested-externs]
builtin-c2c.c:2212:2: error: implicit declaration of function ‘SLang_init_tty’ [-Werror=implicit-function-declaration]
  SLang_init_tty(0, 0, 0);
  ^
builtin-c2c.c:2212:2: error: nested extern declaration of ‘SLang_init_tty’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
mv: cannot stat ‘./.builtin-c2c.o.tmp’: No such file or directory
tools/build/Makefile.build:77: recipe for target 'builtin-c2c.o' failed

Thanks,

Kim