From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754023AbcIUHjf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 03:39:35 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:59487 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751736AbcIUHjD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 03:39:03 -0400
Date: Wed, 21 Sep 2016 09:39:05 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: staging/greybus: undefined Kconfig symbols
Message-ID: <20160921073905.GA31263@kroah.com>
References: <CAD3Xx4JUgT+wBJZP-ez_-D7c3K3T9xhE3daKJ4S0-x_xwqMVUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD3Xx4JUgT+wBJZP-ez_-D7c3K3T9xhE3daKJ4S0-x_xwqMVUA@mail.gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 21, 2016 at 08:30:01AM +0200, Valentin Rothberg wrote:
> Hi Greg,

<fixing odd email address you used for me...>

> checkkconfigsymbols.py found some undefined Kconfig symbols (see
> below) in the Makefile and Kconfig file.  I could not find any patch
> adding those symbols.  Are there patches queued somewhere else?
> 
> Best regards,
>  Valentin
> 
> GREYBUS_AUDIO_MSM8994
> Referencing files: drivers/staging/greybus/Makefile
> Similar symbols: GREYBUS_AUDIO, GREYBUS_GPIO, GREYBUS_SDIO, GREYBUS_USB
> Commits changing symbol:
> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")

This one is tricky, as parts of this audio driver depended on an
out-of-tree qualcomm audio driver.  It will be unwound over time to not
depend on that mess.

> MEDIA
> Referencing files: drivers/staging/greybus/Kconfig
> Similar symbols: COMEDI, EDAC, EISA, HID_CMEDIA, LANMEDIA, MDIO,
> MEDIA_CEC, MEDIA_TUNER, MEMDMA0, MEMDMA1
> Commits changing symbol:
> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")
> - 847175e8e660 ("greybus: audio: Fetch jack_mask, button_mask from
> module's topology data")
> - 64a7e2cceb75 ("greybus: audio: Added jack support to audio module")

Ugh, this should be CONFIG_MEDIA_SUPPORT, right?  If so, I'll make a
patch to change this, that was my fault.

> USB_HSIC_USB3613
> Referencing files: drivers/staging/greybus/Makefile
> Similar symbols: USB_FSL_USB2, USB_GSPCA_SPCA561, USB_GSPCA_STK1135,
> USB_GSPCA_T613, USB_HCD_SSB, USB_HSIC_USB3503, USB_HSIC_USB4604,
> USB_RENESAS_USB3, USB_SI4713, USB_SISUSBVGA
> Commits changing symbol:
> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")
> - 7d0493d191ab ("greybus: only build arche platform driver if usb3613
> is enabled")

This is a driver that has yet to be queued up, give us a few weeks to
add it, and then it will probably be merged into the arche-platform
driver as they both depend on each other.

thanks,

greg k-h