From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756257AbcIUKPf (ORCPT ); Wed, 21 Sep 2016 06:15:35 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57215 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750822AbcIUKPe (ORCPT ); Wed, 21 Sep 2016 06:15:34 -0400 Date: Wed, 21 Sep 2016 12:15:31 +0200 From: Boris Brezillon To: Daniel Walter , computersforpeace@gmail.com Cc: linux-mtd@lists.infradead.org, Richard Weinberger , dwmw2@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Message-ID: <20160921121531.7786ee9b@bbrezillon> In-Reply-To: <984fd8eb53b742bd46e7b42605ae4e0ceaf5ba08.1474450295.git.dwalter@sigma-star.at> References: <984fd8eb53b742bd46e7b42605ae4e0ceaf5ba08.1474450295.git.dwalter@sigma-star.at> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Sep 2016 11:43:56 +0200 Daniel Walter wrote: > From: Richard Weinberger > > If the master device has callbacks for _get/put_device() > and this MTD has slaves a get_mtd_device() call on paritions > will never issue the registered callbacks. > Fix this by propagating _get/put_device() down. Brian, can we have this one queued for 4.9? I can't take it in my tree if you want, but it's probably better if it's in the mtd tree. > > Reviewed-by: Boris Brezillon > Signed-off-by: Richard Weinberger > --- > drivers/mtd/mtdpart.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c > index 1f13e32..ec852fa 100644 > --- a/drivers/mtd/mtdpart.c > +++ b/drivers/mtd/mtdpart.c > @@ -317,6 +317,18 @@ static int part_block_markbad(struct mtd_info *mtd, loff_t ofs) > return res; > } > > +static int part_get_device(struct mtd_info *mtd) > +{ > + struct mtd_part *part = mtd_to_part(mtd); > + return part->master->_get_device(part->master); > +} > + > +static void part_put_device(struct mtd_info *mtd) > +{ > + struct mtd_part *part = mtd_to_part(mtd); > + part->master->_put_device(part->master); > +} > + > static int part_ooblayout_ecc(struct mtd_info *mtd, int section, > struct mtd_oob_region *oobregion) > { > @@ -463,6 +475,12 @@ static struct mtd_part *allocate_partition(struct mtd_info *master, > slave->mtd._block_isbad = part_block_isbad; > if (master->_block_markbad) > slave->mtd._block_markbad = part_block_markbad; > + > + if (master->_get_device) > + slave->mtd._get_device = part_get_device; > + if (master->_put_device) > + slave->mtd._put_device = part_put_device; > + > slave->mtd._erase = part_erase; > slave->master = master; > slave->offset = part->offset;